Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ZF components. Zend_Feed #9240

Closed
okorshenko opened this issue Apr 13, 2017 · 6 comments
Closed

Upgrade ZF components. Zend_Feed #9240

okorshenko opened this issue Apr 13, 2017 · 6 comments
Assignees
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed up for grabs

Comments

@okorshenko
Copy link
Contributor

okorshenko commented Apr 13, 2017

Description
Upgrade components from ZF1 to ZF2

As a long term goal, we would like to eliminate knowledge about 3rd party libraries from Magento code base. Magento code still can use 3rd party libraries, but they must be wrapped by Magento interfaces and classes (adapters) so that 3rd party libraries can be easily substituted by newest versions or alternative implementations.

Acceptance Criteria

  1. Magento interfaces are defined and can be used instead of ZF1 classes in Magento code
  2. Default implementations for new interfaces are defined and configured as the preferences for new interfaces
  3. Client code of the ZF1 components is refactored to use Magento interfaces
  4. Zend classes are used as private services in Magento adapters
  5. Backward compatibility is preserved
  6. ZF1 components are updated to ZF2

List of the components

# Component Name
(total usages count)
Module Name Usages Count
1 Zend_Feed (total: 3) Magento\Rss 3
@ldusan84
Copy link
Contributor

I would like to take this one for start please.

@peterjaap
Copy link
Contributor

@okorshenko I'm looking to pick this issue up, but I'm struggling with point 5 of BC. What do you mean with BC in this regard? If we swap out the hardcoded Zend_Feed in app/code/Magento/Rss/Model/Rss.php with an adapter, it'll break BC in some cases.

@korosti2
Copy link

@okorshenko Thank you for report
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.

@ldusan84
Copy link
Contributor

@okobchenko @korosti2 @peterjaap I find it very hard to understand what's happening here, as the pull request is waiting: #9347

@magento-engcom-team
Copy link
Contributor

Closing the issue. See PR details here: #9347

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label May 12, 2018
magento-devops-reposync-svc pushed a commit that referenced this issue Oct 8, 2024
…fix-09052024

Cia 2.4.8 beta1 develop bugfix 09052024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed up for grabs
Projects
None yet
Development

No branches or pull requests

5 participants