Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ZF components. Zend_Wildfire #9241

Closed
okorshenko opened this issue Apr 13, 2017 · 2 comments
Closed

Upgrade ZF components. Zend_Wildfire #9241

okorshenko opened this issue Apr 13, 2017 · 2 comments
Assignees
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development up for grabs

Comments

@okorshenko
Copy link
Contributor

okorshenko commented Apr 13, 2017

Description
Upgrade components from ZF1 to ZF2

As a long term goal, we would like to eliminate knowledge about 3rd party libraries from Magento code base. Magento code still can use 3rd party libraries, but they must be wrapped by Magento interfaces and classes (adapters) so that 3rd party libraries can be easily substituted by newest versions or alternative implementations.

Acceptance Criteria

  1. Magento interfaces are defined and can be used instead of ZF1 classes in Magento code
  2. Default implementations for new interfaces are defined and configured as the preferences for new interfaces
  3. Client code of the ZF1 components is refactored to use Magento interfaces
  4. Zend classes are used as private services in Magento adapters
  5. Backward compatibility is preserved
  6. ZF1 components are updated to ZF2

List of the components

# Component Name
(total usages count)
Module Name Usages Count
1 Zend_Wildfire (total: 3) Framework\Profiler 3
@SolsWebdesign
Copy link
Contributor

SolsWebdesign commented May 13, 2017

Zend_Wildfire was deprecated from ZendFramework 2.0 :
http://zend-framework-community.634137.n4.nabble.com/Zend-Framework-2-0-0RC1-Released-td4655931.html
states that:

  • Removed Zend\Wildfire, as its API was specific to ZF1, and because we can easily leverage FirePHP at this time.

parts of the FirePHP can be found in Zend\Log\Writer e.g. vendor\zendframework\zend-log\src\Writer\FirePhp.php
in the current Magento\Framework\Profiler\Driver\Standard\Output\Firebug.php
there are 3 usages :
Zend_Wildfire_Channel_HttpHeaders
Zend_Wildfire_Plugin_FirePhp_TableMessage
Zend_Wildfire_Plugin_FirePhp
of which the first two don't really have any alternatives at the moment. One could use the original FirePHP library instead and include it like suggested here (http://stackoverflow.com/questions/13727592/using-firephp-with-zend-framework-2) but to be honest the FirePHP library is really outdated and does not work with the latest Firefox anymore.

SolsWebdesign added a commit to SolsWebdesign/magento2 that referenced this issue May 13, 2017
Zend_Wildfire was deprecated from ZendFramework 2.0. Some parts of FirePhp are now used in Zend\Log\Writer but the FirePhp library itself is outdated and does not work in the latest Firefox anymore. These files, Firebug and FirebugTest, can be removed.
@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Application Framework up for grabs labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development up for grabs
Projects
None yet
Development

No branches or pull requests

4 participants