Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect order date in Orders grid #9426

Closed
potatocommerce opened this issue Apr 27, 2017 · 8 comments
Closed

Incorrect order date in Orders grid #9426

potatocommerce opened this issue Apr 27, 2017 · 8 comments
Labels
bug report Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@potatocommerce
Copy link

We have noticed that Magento 2.1.4 displaying incorrect order date in the grid.

Preconditions

  1. Found with Minsk timezone, reproduced on some others
  2. Magento 2.1.4 CE

Steps to reproduce

  1. Place an order
  2. Go to the orders grid

Expected result

Correct time in the grid

Actual result

Incorrect time in the grid. It is displaying correct date on order page though. It is always display time as XX:04:00 AM/PM, even 14:04:00 PM which is already a bug (it should be 02 PM, not 14 PM).
http://i.imgur.com/SyX9QmU.png
http://i.imgur.com/V0NXTUm.png
http://i.imgur.com/h3c6JYf.png
@YevSent
Copy link
Contributor

YevSent commented Apr 27, 2017

Hi, @potatocommerce, thanks for reporting. I've created internal ticket MAGETWO-68795.

@YevSent YevSent added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Sales labels Apr 27, 2017
@JacobDrummond JacobDrummond mentioned this issue Apr 28, 2017
Closed
@Tjitse-E
Copy link
Contributor

@potatocommerce you can try if this pull requests fixes this issue #8336

@Ctucker9233
Copy link

@joni-jones related issue #8422.

@YevSent
Copy link
Contributor

YevSent commented May 4, 2017

@Ctucker9233 how #8422 is related to this issue? This issue affects only time format in sales order grid and does not relate to the Newsletter.

@YevSent
Copy link
Contributor

YevSent commented May 4, 2017

@Tjitse-E, mentioned PR did not have the full fix for this issue.

@Ctucker9233
Copy link

@joni-jones I thought this issue had to do with the time stamp not displaying correctly. I have noticed the same behavior in the newsletter module. If you do not think that they are related, then feel free to ignore.

AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jun 14, 2017
By default, show times in admin grids in the store timezone.
049cc45 
fixes magento#9426

This test basically said, use the column config value, or use FALSE:

    $timezone = isset($this->getConfiguration()['timezone'])
        ? $this->booleanUtils->convert($this->getConfiguration()['timezone'])
        : false;

The only config values currently present in the code set the 'timezone'
config to FALSE using `<timezone>false</timezone>`. There are 0 occurances
of `<timezone>true</timezone>` in the code base at this time. This makes
me believe that the default value should not be FALSE but TRUE. Otherwise
the outcome will always be FALSE, be it explicit or by default.

This way the product review created_at times will be the same in the
catalog/product/edit adminhtml page as well as on the Marketing | Reviews
grid. They were not equal before this commit.

The same goes for the CMS page grid, the CMS block grid, the customer grid,
the online customers grid, and the sales grids.

I believe admins wint to see these times in their configured time zone and
not in UTC. Otherwise someone can appear to have placed an order in the
future which is very confusing.
@AntonEvers AntonEvers mentioned this issue Jun 14, 2017
Merged
4 tasks
@korostii
Copy link
Contributor

Hello @magento-team,
Could you please announce in which version is this fix scheduled to ship?
It's a bit confusing to see the issue closed while the latest (2.1.7) release still has the bug inside.

magento-team pushed a commit that referenced this issue Jun 27, 2017
@rganin
MAGETWO-68795: [Github] Incorrect order time in sales order grid #9426
0150eae
magento-team pushed a commit that referenced this issue Jun 27, 2017
@rganin
MAGETWO-68795: [Github] Incorrect order time in sales order grid #9426
c4c0cf8
magento-team pushed a commit that referenced this issue Jun 27, 2017
@rganin
Merge pull request #1229 from magento-troll/PR_Troll
68a79d9 
MAGETWO-68795: [Github] Incorrect order time in sales order grid #9426
MAGETWO-57221: Visual Swatch - User with Custom access cannot change or add color swatches to an attribute.
MAGETWO-69971: Random fails in Magento\SalesRule\Model\ResourceModel\Rule\CollectionTest
MAGETWO-69714: Cannot delete product tier-prices
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@magento-team @YevSent @Tjitse-E @Ctucker9233 @potatocommerce @korostii