Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Grid Mass action Select / Unselect All issue #9610

Closed
minesh0111 opened this issue May 12, 2017 · 1 comment
Closed

Admin Grid Mass action Select / Unselect All issue #9610

minesh0111 opened this issue May 12, 2017 · 1 comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@minesh0111
Copy link
Contributor

Admin Grid Mass Action Select All and Unselect All work only on primary_key of collection object no matter if we set other field as mass action filed using grid method setMassactionIdField other than primar_key

Preconditions

  1. Magento version 2.1.3

Steps to reproduce

  1. Found this issue while creating custom module where i need mass action id filed other than primary_key of collection.

Expected result

  1. It should Select All and Unselect All on click of option
  2. It should post MassactionIdField on submit

Actual result

  1. Checkbox checked and unchecked not working on click of option
  2. Always post primary_key value of collection on submit
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 12, 2017
@minesh0111
Admin Grid Mass action Select / Unselect All issue magento#9610
0e188b1
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 12, 2017
@minesh0111
Merge pull request #1 from minesh0111/minesh0111-patch-1
d0f3cdf 
Admin Grid Mass action Select / Unselect All issue magento#9610
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 15, 2017
@minesh0111
Travis CI Fixed For issue magento#9610
5b66980
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 15, 2017
@minesh0111
Travis CI Fixed For issue magento#9610
c8de33f
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 20, 2017
@minesh0111
Admin Grid Mass action Select / Unselect All issue magento#9610
d8ad06b
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 20, 2017
@minesh0111
Travis CI Fixed For issue magento#9610
f599252
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 29, 2017
@minesh0111
Travis CI Fixed For issue magento#9610
d51481d
minesh0111 added a commit to minesh0111/magento2 that referenced this issue May 29, 2017
@minesh0111
Travis CI Fixed For issue magento#9610
9f8dc0f
magento-team pushed a commit that referenced this issue Jun 29, 2017
@fooman
MAGETWO-69167: Admin Grid Mass action Select / Unselect All issue #9610
3bfcbd2 
#9611

 - Merge Pull Request #9611 from minesh0111/magento2:develop
 - Merged commits:
   1. 0e188b1
   2. d0f3cdf
   3. 5b66980
   4. c8de33f
   5. d8ad06b
   6. f599252
   7. 91c8403
   8. 26baaaa
   9. d892cfe
   10. beed22a
   11. 74d1f4e
   12. 6f25f42
   13. 1b7ae51
   14. a6ff649
   15. d51481d
   16. 9f8dc0f
   17. f4c7ada
   18. 808feed
   19. 7ced70e
   20. 9a5d880
   21. 1f77bd1
   22. 1c401d1
   23. e188285
   24. 40871b9
   25. 12d4869
magento-team pushed a commit that referenced this issue Jun 29, 2017
MAGETWO-69167: Admin Grid Mass action Select / Unselect All issue #9610
8794ccb 
#9611
@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added 2.2.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 20, 2017
@magento-engcom-team
Copy link
Contributor

@minesh0111, thank you for your report.
The issue is already fixed in 2.2.0

@osrecio osrecio mentioned this issue Dec 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minesh0111 @magento-engcom-team