-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product reviews list template paging issue. #970
Labels
bug report
Fixed in 2.3.x
The issue has been fixed in 2.3 release line
Issue: Format is not valid
Gate 1 Failed. Automatic verification of issue format is failed
Comments
In this place really ugly js code, I think it should be rewrited |
@tzyganu, we created a ticket in the internal tracker: MAGETWO-32939. We will update you once we have any news on the resolution and fix availability time. Thank you! |
@tzyganu, this issue is fixed and already available on public. Please, check it again. |
@vpelipenko Thanks for the fix. Seams to be working nice. |
magento-team
pushed a commit
that referenced
this issue
Apr 11, 2017
MAGETWO-66789: [Backport] - [Performance] No empty image placeholder …
magento-team
pushed a commit
that referenced
this issue
Jun 7, 2017
… the layered navigation options are sometimes being cached using the wrong store id. #970
magento-team
pushed a commit
that referenced
this issue
Dec 11, 2017
magento-team
pushed a commit
that referenced
this issue
Dec 11, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-85311: Added namespace to product videos fotorama events #12469 #991 - MAGETWO-85300: 8437: Silent error when an email template is not found #970 - MAGETWO-85293: 12613: Verbiage Update Required: Product Image Watermark size Validation Message. #985 - MAGETWO-85286: 8176: LinkManagement::getChildren() does not include product visibility. #986 - MAGETWO-85285: 12482: Sitemap image links in MultiStore #935 - MAGETWO-84955: Set Current Store from Store Code if isUseStoreInUrl #12529 - MAGETWO-84764: NewRelic: Disables Module Deployments, Creates new Deploy Marker Command #12477 - MAGETWO-84439: 12180 Remove unnecessary use operator for Context, causes 503 error i… #12220
fe-lix-
pushed a commit
to fe-lix-/magento2
that referenced
this issue
Apr 29, 2018
MSI-918: Need to refactor test ReservationPlacingDuringRegisterProductsSaleTest::testRegisterProductsSale as we don't make source deduction at the time of RegisterSales Anymore.
magento-engcom-team
added
Fixed in 2.3.x
The issue has been fixed in 2.3 release line
Issue: Format is not valid
Gate 1 Failed. Automatic verification of issue format is failed
labels
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug report
Fixed in 2.3.x
The issue has been fixed in 2.3 release line
Issue: Format is not valid
Gate 1 Failed. Automatic verification of issue format is failed
In the file
/app/code/Magento/Review/view/frontend/templates/review.phtml
there is a js function calledprocessReviews
that (from what I understood) makes the pager use ajax.but there is a problem with the
<a>
tag selector for the paging.Right now the selector looks like this:
$('.pages a')
on lineThis works with a default install, but if I add other
<a>
elements anywhere in the page that match this selector, clicking on them will trigger an ajax request. This is may not be the desired effect.I think that the DOM selector should be
$('#product-review-container .pages a')
to limit the selected elements to the reviews paging.PS: I know I can do a pull request, but I prefer to let you fix this in case I'm wrong.
The text was updated successfully, but these errors were encountered: