Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCacheTags for price issue #9877

Closed
Styopchik opened this issue Jun 8, 2017 · 7 comments
Closed

getCacheTags for price issue #9877

Styopchik opened this issue Jun 8, 2017 · 7 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Styopchik
Copy link

Styopchik commented Jun 8, 2017

Preconditions

Problem on Magento 2.1.5.

Steps to reproduce

\Magento\Catalog\Block\Category\Plugin\PriceBoxTags::getTaxRateIds in line 104

Actual result

calls $rateRequest like this:
$rateRequest = $this->getTaxCalculation()->getRateRequest(
$billingAddress,
$shippingAddress,
$customerTaxClassId,
$this->scopeResolver->getScope()->getId(),
$this->customerSession->getCustomerId()
);

Expected Result

but the original method accepts $shippingAddress first

public function getRateRequest(
$shippingAddress = null,
$billingAddress = null,
$customerTaxClass = null,
$store = null,
$customerId = null
)

@veloraven
Copy link
Contributor

@Styopchik thank you for your feedback.
Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.

@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Progress: needs update Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@Styopchik thank you for your report. It would be very helpful if you can create Pull Request for this issue

@okorshenko okorshenko added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 14, 2017
@keyurshah070
Copy link
Contributor

will do it

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-75328

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop labels Sep 19, 2017
@magento-engcom-team
Copy link
Contributor

@Styopchik, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@okorshenko
Copy link
Contributor

@Styopchik thank you for your report. The issue is already fixed in 2.2-develop branch (PR: #11154 by @denysbabenko) and will be available in the Magento 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 4, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants