-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getCacheTags for price issue #9877
Comments
@Styopchik thank you for your feedback. |
@Styopchik thank you for your report. It would be very helpful if you can create Pull Request for this issue |
will do it |
Internal ticket to track issue progress: MAGETWO-75328 |
@Styopchik, thank you for your report. |
@Styopchik thank you for your report. The issue is already fixed in 2.2-develop branch (PR: #11154 by @denysbabenko) and will be available in the Magento 2.2.2 release |
Internal ticket to track issue progress: MAGETWO-80511 |
Preconditions
Problem on Magento 2.1.5.
Steps to reproduce
\Magento\Catalog\Block\Category\Plugin\PriceBoxTags::getTaxRateIds
in line 104Actual result
calls $rateRequest like this:
$rateRequest = $this->getTaxCalculation()->getRateRequest(
$billingAddress,
$shippingAddress,
$customerTaxClassId,
$this->scopeResolver->getScope()->getId(),
$this->customerSession->getCustomerId()
);
Expected Result
but the original method accepts $shippingAddress first
public function getRateRequest(
$shippingAddress = null,
$billingAddress = null,
$customerTaxClass = null,
$store = null,
$customerId = null
)
The text was updated successfully, but these errors were encountered: