Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for file category image uploader #10033

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Jun 23, 2017

Description

Manual testing scenarios

  1. Changes that were made on 70d3468 commit broke category image uploading in many browsers, as FormData.set() is onnly supported in Chrome and Firefox (in Firefox it also depends on user browser settings)
  2. New implementation (changing set() into append()) is working correctly, because such element doesn't exists in FormData at the time of sending, and it is well supported across browsers.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 23, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 23, 2017
@magento-team magento-team merged commit 1948b8d into magento:develop Jun 26, 2017
@Bartlomiejsz Bartlomiejsz deleted the FileUploader_Fix branch June 27, 2017 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants