-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fulltext/keyword search field for product admin grid #10089
Add fulltext/keyword search field for product admin grid #10089
Conversation
variable $field is not needed, so warnings can be ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grid Search is not a responsibility of CatalogSearch module, as CatalogSearch is responsible just for Front-End search.
Grid Search is the responsibility of Catalog module, so fix should be placed there
Thus, you can change directly product_listing.xml
@maghamed |
@josefbehr I looked through the CatalogSearch code and found that there is already code responsible for Backend search Magento\CatalogSearch\Model\Search\Catalog so, let's leave your fix in CatalogSearch, because you right, for now, we have the dependency on this Collection |
* | ||
* @var SearchCollection | ||
*/ | ||
protected $searchCollection; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use private instead of protected
/** | ||
* {@inheritdoc} | ||
* | ||
* @SuppressWarnings("unused") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to UnusedFormalParam
BTW, could you please test that general Admin Search works correctly. Search in Products doesn't work because for now there is no Search on Product grid. |
@maghamed |
hey @josefbehr. For me search for Orders works as expected I thought that Search for Products will work after your changes. If not, need to double check that. All that global search does is redirects on Order/Customer/Page/Product grid with ?search GET parameter and whether Grid supports search - it applies the filter. |
…talog-keyword-search
- Code style fixes
Fixes applied according to review
- Declared introduced dependency on the module Ui
@magento-team Can this be backported to 2.2? |
Description
This adds a keyword search field (like on sales_order_grid) to catalog_product_grid (product_listing)
Manual testing scenarios
Fixes issues
Contribution checklist