Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for isoneof condition in catalogrule #10094

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Fix for isoneof condition in catalogrule #10094

merged 1 commit into from
Jul 5, 2017

Conversation

duckchip
Copy link
Contributor

@duckchip duckchip commented Jun 29, 2017

Description

When comparing the SalesRule module with the CatalogRule module, i noticed a small difference in the setConditionFormName function. The SetJsFormObject wasn't called in the SalesRule module. When removing it from the CatalogRule module, the error disappeared. Probably had to do with setting the wrong object on the tree. It called the unchecked function on the form instead of the condition.

This should solve the problem.

Fixed Issues (if relevant)

  1. Cart Price Rules: Category selection UI for Conditions do not come up. #6396: Cart Price Rules: Category selection UI for Conditions do not come up.

Manual testing scenarios

  1. Create price rule with condition 'category is one of ...'
  2. Save the rule
  3. Re-open the rule and try to change the category id value

Following Javascript error will appear
Uncaught ReferenceError: catalog_rule_form is not defined at Ext.tree.TreePanel.Enhanced.eval (eval at <anonymous> (legacy-build.min.js:1), <anonymous>:156:9) at Ext.util.Event.fire (ext-tree.js:29) at Ext.tree.TreePanel.Enhanced.fireEvent (ext-tree.js:29) at Ext.tree.CheckboxNodeUI.check (ext-tree-checkbox.js:193) at El.Flyweight.<anonymous> (ext-tree.js:9) at HTMLInputElement.h (ext-tree.js:33) at HTMLInputElement.M (legacy-build.min.js:8)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 29, 2017

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants