Fix for isoneof condition in catalogrule #10094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When comparing the SalesRule module with the CatalogRule module, i noticed a small difference in the setConditionFormName function. The SetJsFormObject wasn't called in the SalesRule module. When removing it from the CatalogRule module, the error disappeared. Probably had to do with setting the wrong object on the tree. It called the unchecked function on the form instead of the condition.
This should solve the problem.
Fixed Issues (if relevant)
Manual testing scenarios
Following Javascript error will appear
Uncaught ReferenceError: catalog_rule_form is not defined at Ext.tree.TreePanel.Enhanced.eval (eval at <anonymous> (legacy-build.min.js:1), <anonymous>:156:9) at Ext.util.Event.fire (ext-tree.js:29) at Ext.tree.TreePanel.Enhanced.fireEvent (ext-tree.js:29) at Ext.tree.CheckboxNodeUI.check (ext-tree-checkbox.js:193) at El.Flyweight.<anonymous> (ext-tree.js:9) at HTMLInputElement.h (ext-tree.js:33) at HTMLInputElement.M (legacy-build.min.js:8)
Contribution checklist