Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return URL in getThumbnailUrl instead of nothing #10106

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Return URL in getThumbnailUrl instead of nothing #10106

merged 2 commits into from
Jun 30, 2017

Conversation

samgranger
Copy link
Contributor

@samgranger samgranger commented Jun 30, 2017

In Magento/Catalog/Helper/Product the getThumbnailUrl method currently only returns an empty string, this should, of course, return the Product Thumbnail Url.

Fixed Issues (if relevant)

n/a

Manual testing scenarios

$this->productHelper->getThumbnailUrl($product);

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

In Magento/Catalog/Helper/Product the getThumbnailUrl method currently only returns an empty string, this should, of course, return the Product Thumbnail Url.
@okorshenko okorshenko self-assigned this Jun 30, 2017
@okorshenko okorshenko added this to the June 2017 milestone Jun 30, 2017
@magento-team magento-team merged commit 0ce42ed into magento:develop Jun 30, 2017
magento-team pushed a commit that referenced this pull request Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants