Return URL in getThumbnailUrl instead of nothing #10106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Magento/Catalog/Helper/Product the getThumbnailUrl method currently only returns an empty string, this should, of course, return the Product Thumbnail Url.
Fixed Issues (if relevant)
n/a
Manual testing scenarios
$this->productHelper->getThumbnailUrl($product);
Contribution checklist