Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1 - Allow to use text swatch 0 #10282

Merged
merged 2 commits into from
Jul 18, 2017
Merged

2.1 - Allow to use text swatch 0 #10282

merged 2 commits into from
Jul 18, 2017

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jul 18, 2017 •
edited by okorshenko
Loading

Description

When we're trying to put "0" value into product attribute options - we're getting following error:
Admin is a required field in the each row.
This issue was already fixed in 2.2, but wasn't backported to 2.1.
See #9619 for more detailed description.

Fixed Issues (if relevant)

  1. Impossible to create Text Swatch 0 (Zero) #9619: Impossible to create Text Swatch 0 (Zero)
  2. Allows you to have 0 as a option #7701: Allows you to have 0 as a option
  3. Product Attributes - Size 0 #10266: Product Attributes - Size 0

Manual testing scenarios

  1. Try to create product attribute text swatch with value "0" (zero)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Corefix @ihor-sviziev
Allows you to have 0 as a option
2b46c8a 
Corrects validation of options, to allow you to have 0 as a value

(cherry picked from commit f2c66b6)
@Corefix @ihor-sviziev
Update EavAttribute.php
bc8877a 
(cherry picked from commit c5cddd9)
@okorshenko okorshenko self-assigned this Jul 18, 2017
@okorshenko okorshenko added this to the July 2017 milestone Jul 18, 2017
@magento-team magento-team merged commit bc8877a into magento:2.1-develop Jul 18, 2017
magento-team pushed a commit that referenced this pull request Jul 18, 2017
MAGETWO-70838: 2.1 - Allow to use text swatch 0 #10282
b92d4e3
@ihor-sviziev ihor-sviziev deleted the allow-to-use-text-swatch-0 branch October 5, 2017 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Progress: accept Release Line: 2.1
Projects
None yet
Milestone
July 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@ihor-sviziev @magento-team @okorshenko @Corefix