Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the usage of Zend_Json::encode in the setup marketplace tests #10329

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Replace the usage of Zend_Json::encode in the setup marketplace tests #10329

merged 1 commit into from
Jul 26, 2017

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Jul 26, 2017 •
edited
Loading

Description

Replace the usage of Zend_Json::encode in the setup marketplace controller tests. Since Zend_Json is now in EOL

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Json #9236: Upgrade ZF components. Zend_Json

Manual testing scenarios

  1. Running the test case setup/src/Magento/Setup/Test/Unit/Controller/MarketplaceTest.php should still be green,

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Jul 26, 2017
@ishakhsuvarov ishakhsuvarov added this to the July 2017 milestone Jul 26, 2017
@magento-team magento-team merged commit cb858f7 into magento:develop Jul 26, 2017
magento-team pushed a commit that referenced this pull request Jul 26, 2017
@ishakhsuvarov
MAGETWO-71034: Replace the usage of Zend_Json::encode in the setup ma…
f163239 
…rketplace tests #10329
@dmanners dmanners deleted the remove-zend-json-setup-unit-test branch July 26, 2017 19:49
magento-team pushed a commit that referenced this pull request Oct 3, 2017
@irenelagno
MAGETWO-80180: Replace the usage of Zend_Json::encode in the setup ma…
ac3a840 
…rketplace tests #10329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
July 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@dmanners @magento-team @ishakhsuvarov