Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Zend_Json from the Webapi #10333

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Remove Zend_Json from the Webapi #10333

merged 2 commits into from
Jul 26, 2017

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Jul 26, 2017 •
edited by ishakhsuvarov
Loading

Description

Remove Zend_Json from the Webapi

  • inject the new \Magento\Framework\Serialize\Serializer\Json
  • call unserialize,
  • Update the catch to \InvalidArgumentException

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Json #9236: Upgrade ZF components. Zend_Json

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Remove Zend_Json from the Webapi
1fa737e 
 - inject the new \Magento\Framework\Serialize\Serializer\Json
 - call unserialize,
 - Update the catch to \InvalidArgumentException
@ishakhsuvarov ishakhsuvarov self-assigned this Jul 26, 2017
@ishakhsuvarov ishakhsuvarov added this to the July 2017 milestone Jul 26, 2017
dmanners
dmanners commented Jul 26, 2017
View reviewed changes
lib/internal/Magento/Framework/Webapi/Rest/Request/Deserializer/Json.php
\Magento\Framework\Json\Decoder $decoder,
State $appState,
\Magento\Framework\Serialize\Serializer\Json $serializer = null
) {
$this->decoder = $decoder;
Copy link
Contributor Author

@dmanners dmanners Jul 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be marked as deprecated

@magento-team magento-team merged commit f2a9362 into magento:develop Jul 26, 2017
magento-team pushed a commit that referenced this pull request Jul 26, 2017
@ishakhsuvarov
MAGETWO-71040: Remove Zend_Json from the Webapi #10333
d2e2251
@dmanners dmanners deleted the remove-zend-json-from-webapi branch July 26, 2017 19:49
magento-team pushed a commit that referenced this pull request Oct 3, 2017
@irenelagno
MAGETWO-80181: [2.2.x] - Remove Zend_Json from the Webapi #10333
8b2d441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
July 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@dmanners @magento-team @ishakhsuvarov