Remove zend json from migration #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inject the new \Magento\Framework\Serialize\Serializer\Json class, - update _jsonDecode method parameter default from Zend_Json constant, - update _jsonDecode to call the new Serializer method version
dmanners
commented
Jul 26, 2017
| @@ -694,10 +704,12 @@ public function getCompositeModules() | |||
| * | |||
| * @param string $encodedValue | |||
| * @param int $objectDecodeType | |||
| * @return mixed | |||
| * @return array|bool|float|int|mixed|null|string | |||
There was a problem hiding this comment.
Again not happy that the return and the throws have changed been added but not really sure if this is ok/if there is a better option in this case.
There was a problem hiding this comment.
I assume same return type as SerializerInterface suggests may be used
Since it's Json implementation currently has inheritdoc.
There was a problem hiding this comment.
We will take care about this on our side.
magento-team
pushed a commit
that referenced
this pull request
Jul 27, 2017
magento-team
pushed a commit
that referenced
this pull request
Jul 27, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 3, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the Zend_Json call from the Setup/Migration.php …
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist