Skip to content

Translate order getCreatedAtFormatted() to store locale #10390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Translate order getCreatedAtFormatted() to store locale #10390

wants to merge 2 commits into from

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Aug 1, 2017

Description

Extend getDefaultLocale() to allow fetching scoped values. Use this in getCreatedAtFormatted() so created_at date of order will be translated in emails to locale being used in that store view.

Fixed Issues (if relevant)

  1. None that I could find.

Manual testing scenarios

  1. Set default locale of your store to any language but English.
  2. Create order and send confirmation email.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov added this to the August 2017 milestone Aug 1, 2017
@okorshenko okorshenko self-assigned this Aug 8, 2017
@okorshenko
Copy link
Contributor

Hi @JeroenVanLeusden thank you for your contributio.

Unfortunately, we can not accept such changes. ReolverInterface has @api tag. In this case we must follow Backward Compatibility Policy

Closing this PR. Feel free submit new PR if you would like to reimplement this following Backward Compatibility Policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants