Skip to content

Add missing translations in Customer module #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2017
Merged

Add missing translations in Customer module #10604

merged 1 commit into from
Aug 22, 2017

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Aug 21, 2017 •
edited by jessetaverne
Loading

Description

Add missing translations in Customer module (taken from https://github.com/magento/magento2/blob/develop/app/code/Magento/Customer/Setup/CustomerSetup.php).

Fixed Issues (if relevant)

  1. None that I could find.

Manual testing scenarios

  1. Set locale of backend user to something different then english.
  2. Add new customer and see that labels in Account Information are still english.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@JeroenVanLeusden JeroenVanLeusden mentioned this pull request Aug 21, 2017
Closed
@ishakhsuvarov ishakhsuvarov added this to the August 2017 milestone Aug 21, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Aug 22, 2017
@magento-team magento-team merged commit 8f6fb81 into magento:develop Aug 22, 2017
magento-team pushed a commit that referenced this pull request Aug 22, 2017
@ishakhsuvarov
MAGETWO-71769: Add missing translations in Customer module #10604
e814e2d
magento-team pushed a commit that referenced this pull request Aug 22, 2017
@ishakhsuvarov
Merge pull request #1430 from magento-engcom/develop-prs
df7d1c7 
[EngCom] Public Pull Requests
 - MAGETWO-71769: Add missing translations in Customer module #10604
 - MAGETWO-71761: Resolve fatal error in repository generator #10601
 - MAGETWO-71603: Translate order getCreatedAtFormatted() to store locale #10491
@JeroenVanLeusden JeroenVanLeusden deleted the patch-2 branch September 5, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@JeroenVanLeusden @magento-team @ishakhsuvarov