-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static versioning and styles minification break email fonts styles #8241 #10638
Conversation
This seems to fix only the minification issue but I would still like to process this since the version of this extension is really outdated. Do you foresee any issues in any other parts of the app with this change? Adding @Igloczek to the loop for extra comments. |
@miguelbalparda No I don't foresee problems with this change |
@miguelbalparda Could you please re-run Travis build? Looks like random failure |
Restarted |
I'll wait for a reply in #4737 before accepting this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelbalparda This looks good to me. I see no reason to hold off on merging it.
Static versioning and styles minification break email fonts styles #8241
Description
With old version of pelago/emogrifier minified css is not applied to html document(but works fine with normal css). This leads to broken styles in email notifications
Fixed Issues (if relevant)
Manual testing scenarios
Actual result:
Minified inline css is not applied (added by {{inlinecss file="css/email-inline.css"}}) to html document (or applied partially)
Contribution checklist