-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 7.0 and HHVM to Travis-CI as allowed failures #1064
Conversation
Hi @navarr, you are right, there is no major harm to include the into build, but what kind of benefit the red builds will bring? |
@maksek By having the red builds available early (and allowed failing), developers and contributors can recognize issues with unsupported versions early on and make smaller efforts to help support them, as opposed to someone doing all of the grunt work and announcing support. To me this is especially important with new versions of PHP - so that developers have an early warning as to the pitfalls of that platform, I feel. By allowing failures (which this configuration does) it doesn't throw red flags in PRs and such until those allowed failures are removed - which would be done at time of official support. |
@maksek, proposed changes do not do build red but just run test on other php version and ignore results. |
👍 |
Issue is similar to #623. Would be also nice to add hhvm-nightly environment variation. However, this pull request is not ready - no test results are shown on Travis CI for additional configurations with allowed failures. Here is an example of some tests running under HHVM. So, red builds would bring some value as to me, even if there were fatal errors, but grey builds bring no value, they just reveal problem in |
another benefit of having this is to provide bug reports upstream to PHP for things which broke (unwanted) in the new release. |
@navarr, as we can see here https://travis-ci.org/magento/magento2/jobs/52291158 tests wasn't even started due to problem in travis.yml configuration. The same issue we can see on other PHP7 and HHVM jobs. It will be good if you fix it. It will allow us to see real fails on these environments. |
@vpelipenko I'll investigate. What y'all are doing there with mail is a little beyond me, so I'm not sure I'll be able to fix it. But I'll take a look. |
Here is an example https://travis-ci.org/Sanuch/magento2/builds/47961569. Maybe it will help you. |
@navarr, do you have updates? |
This pull request allows developers and contributors to track how Magento tests are faring against hhvm and 7.0; while not raising a red flag for any failures.
It's best to track this data early on so that supporting them can be considered in the future. There's no harm to include them, so why not do so?