Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7.0 and HHVM to Travis-CI as allowed failures #1064

Closed
wants to merge 1 commit into from
Closed

Add 7.0 and HHVM to Travis-CI as allowed failures #1064

wants to merge 1 commit into from

Conversation

navarr
Copy link
Member

@navarr navarr commented Feb 26, 2015

This pull request allows developers and contributors to track how Magento tests are faring against hhvm and 7.0; while not raising a red flag for any failures.

It's best to track this data early on so that supporting them can be considered in the future. There's no harm to include them, so why not do so?

@maksek
Copy link
Contributor

maksek commented Feb 27, 2015

Hi @navarr, you are right, there is no major harm to include the into build, but what kind of benefit the red builds will bring?

@maksek maksek self-assigned this Feb 27, 2015
@navarr
Copy link
Member Author

navarr commented Feb 27, 2015

@maksek By having the red builds available early (and allowed failing), developers and contributors can recognize issues with unsupported versions early on and make smaller efforts to help support them, as opposed to someone doing all of the grunt work and announcing support.

To me this is especially important with new versions of PHP - so that developers have an early warning as to the pitfalls of that platform, I feel.

By allowing failures (which this configuration does) it doesn't throw red flags in PRs and such until those allowed failures are removed - which would be done at time of official support.

@kandy
Copy link
Contributor

kandy commented Feb 27, 2015

@maksek, proposed changes do not do build red but just run test on other php version and ignore results.

@QWp6t
Copy link

QWp6t commented Feb 27, 2015

👍

@orlangur
Copy link
Contributor

orlangur commented Mar 2, 2015

Issue is similar to #623. Would be also nice to add hhvm-nightly environment variation.

However, this pull request is not ready - no test results are shown on Travis CI for additional configurations with allowed failures. Here is an example of some tests running under HHVM.

So, red builds would bring some value as to me, even if there were fatal errors, but grey builds bring no value, they just reveal problem in .travis.yml configuration file itself.

@Flyingmana
Copy link
Member

another benefit of having this is to provide bug reports upstream to PHP for things which broke (unwanted) in the new release.

@vpelipenko
Copy link
Contributor

@navarr, as we can see here https://travis-ci.org/magento/magento2/jobs/52291158 tests wasn't even started due to problem in travis.yml configuration. The same issue we can see on other PHP7 and HHVM jobs. It will be good if you fix it. It will allow us to see real fails on these environments.

@navarr
Copy link
Member Author

navarr commented Mar 25, 2015

@vpelipenko I'll investigate. What y'all are doing there with mail is a little beyond me, so I'm not sure I'll be able to fix it. But I'll take a look.

@vpelipenko
Copy link
Contributor

Here is an example https://travis-ci.org/Sanuch/magento2/builds/47961569. Maybe it will help you.

@vpelipenko
Copy link
Contributor

@navarr, do you have updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants