Move Topmenu CategoryData creation to a public method to enable plugin ... #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesAnelay Thank you for the contribution. The code looks great! ✅ CR: passed |
I thought plugins had to be on public methods, turns out this is not the case so have set the method to protected.
This reverts commit b9fb63e.
vpelipenko
added
the
Issue: Ready for Work
|
Anychance we can get this merged or closed allready? |
|
@JamesAnelay sorry for delay. This pull request will be merged as soon as possible |
vpelipenko
added
in progress
Progress: accept
and removed
Issue: Ready for Work
|
@JamesAnelay your pull request is merged in 0.74.0-beta9. Thank you very much for your contribution and continued support to Magento 2! |
magento-team
pushed a commit
that referenced
this pull request
May 5, 2017
[MPI] PHP7 returns types incompatible with generate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magento provides a couple of nice observers that "Allow extensions to modify select (e.g. add custom category attributes to select)" namely catalog_category_flat_loadnodes_before and page_block_html_topmenu_gethtml_before. However once added to the select there is (I belive) no nice way to add the data to the topmenu.
Currently I need to disable catalog_add_topmenu_items and add my own observer to replace it, not very nice as only I can do this meaning other extensions cannot also add data. I propose moving the generation of $categoryData to a seperate public function so that I can add data with Plugins.