Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Make State/Province required field in checkout view based on settings #10924

Closed
wants to merge 1 commit into from

Conversation

Igloczek
Copy link
Contributor

@Igloczek Igloczek commented Sep 17, 2017

It's the backport of changes present on develop branch, to fix issues described in #9077 also on 2.1.x.

Related commits and issues:

@orlangur
Copy link
Contributor

Will this cover #10897 case?

@Igloczek
Copy link
Contributor Author

@orlangur Yup, it will cover this case too.

@vrann
Copy link
Contributor

vrann commented Sep 26, 2017

@Igloczek thank you for the backport!
We notice one issue which still has to be resolved: when the State/Province is a required field, it is validated on PHP side, but the frontend does not display it as a required for the countries other than USA (i.e. India).

This is how it looks like on 2.1 after the fix:
susp-03

This is how it looks like on develop
develop

@Igloczek
Copy link
Contributor Author

Igloczek commented Oct 13, 2017

To be completely honest with you, I'm afraid that it has to be merged in the current state or rejected, because I don't have time to investigate, especially while we have 2.2 up and backport isn't a crucial thing, because users can just make an upgrade.

@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@magento-engcom-team magento-engcom-team added bugfix Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Nov 7, 2017
@ishakhsuvarov
Copy link
Contributor

@Igloczek I am closing this now per your comment.
Please reopen if you feel like continuing with this one in the future.

@Igloczek Igloczek deleted the required-region-fix branch November 16, 2017 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: needs update Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants