Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disable maintenance mode after running a backup. #11056

Conversation

stevenvdp
Copy link
Contributor

@stevenvdp stevenvdp commented Sep 26, 2017

Description

Keep the initial maintenance mode state before running the backup.
Only disable maintenance mode if it was not setted before.

Github issue: #7951

Fixed Issues (if relevant)

  1. Running setup:backup with maintenance mode already on, disables after completion. #7951: Running setup:backup with maintenance mode already on, disables after completion.

Manual testing scenarios

  1. run > bin\magento maintenance:enable
  2. run > bin\magento setup:backup --db
  3. when backup is complete, you don't see:
    "[SUCCESS]: DB backup completed successfully.
    Disabling maintenance mode"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

heyitsroberthe and others added 3 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
Keep the initial maintenance mode state before running the backup.
Only disable maintenance mode if it was not setted before.

Github issue: magento#7951
@miguelbalparda
Copy link
Contributor

It seems you and @jokeputs are working on the same and #11052 incudes several other fixes for this. Maybe you can work together on the same PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants