Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show different message if DB module version is higher than code modul… #11064

Merged
merged 3 commits into from
Sep 29, 2017
Merged

Show different message if DB module version is higher than code modul… #11064

merged 3 commits into from
Sep 29, 2017

Conversation

schmengler
Copy link
Contributor

@schmengler schmengler commented Sep 26, 2017

…e version

Description

If any schema or data version in the setup_modules database is higher than the current module version in the code, the exception message will suggest running composer install instad of magento setup:upgrade

Fixed Issues (if relevant)

  1. Error Message Is Confusing When Code Base Is Behind Database Module Version #9008: Error Message Is Confusing When Code Base Is Behind Database Module Version
  2. M2 suggests running setup:upgrade if version number of module is higher than expected #9981: M2 suggests running setup:upgrade if version number of module is higher than expected

Manual testing scenarios

  1. change a module version in setup_modules to a higher number
  2. flush cache
  3. open the site

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vrann vrann self-assigned this Sep 27, 2017
@vrann vrann added this to the September 2017 milestone Sep 27, 2017
@vrann
Copy link
Contributor

vrann commented Sep 27, 2017

@schmengler showed the exception to few developers and it was not too clear for them what problem does it indicates. If you don't object I'm going to change the wording a bit:

Magento_Module3 db schema version: defined in codebase - 1.0.0, currently installed - 2.0.0
Magento_Module4 db data version: defined in codebase - 1.0.0, currently installed - 1.0.1

@schmengler
Copy link
Contributor Author

@vrann sounds good, go ahead!

@magento-team magento-team merged commit 008bb5a into magento:2.2-develop Sep 29, 2017
magento-team pushed a commit that referenced this pull request Sep 29, 2017
…than code module #11064

- changed wording of the error
magento-team pushed a commit that referenced this pull request Sep 29, 2017
magento-team pushed a commit that referenced this pull request Sep 29, 2017
…than code module #11064

- changed wording of the error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants