Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2-develop] Add static test to detect blocks without name attribute #11235

Merged
merged 7 commits into from
Oct 20, 2017

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Oct 5, 2017

Description

This change covers an issue when block doesn't contain name attribute in layout file.
As was discussed in #10354 (comment) - need to covert missing block names issue with static test.

Fixed Issues (if relevant)

  1. N/A

Related issues

  1. Add missing block name to allow block customisation #10352: Add missing block name to allow block customisation
  2. Add missing block name to allow block customisation #10354: Add missing block name to allow block customisation
  3. #10824 add name for order items grid default renderer block #10936: Cannot add new columns to item grid in admin sales_order_view layout #10824 add name for order items grid default renderer block
  4. Add static test to detect blocks without name attribute #11092 Add static test to detect blocks without name attribute

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds on Travis CI are green)
  • All new or changed code is covered with unit/integration tests (if applicable)

ihor-sviziev and others added 7 commits October 5, 2017 09:43
Run all static tests on Travis

(cherry picked from commit 117287f)
Fix static test failures

(cherry picked from commit e57ef72)
Add names to blocks in layout XML `catalog_product_view_type_grouped.xml` to make them accessible

(cherry picked from commit a4edec7)
… to be able to extend them using referenceBlock functionality

(cherry picked from commit d2a37e4)
@ihor-sviziev ihor-sviziev changed the title Add static test to detect blocks without name attribute [2.2-develop] Add static test to detect blocks without name attribute Oct 5, 2017
@mzeis
Copy link
Contributor

mzeis commented Oct 6, 2017

The functional test suite timed out. I'll close and re-open the PR to trigger a new build.

@mzeis mzeis closed this Oct 6, 2017
@mzeis mzeis reopened this Oct 6, 2017
@ihor-sviziev
Copy link
Contributor Author

@mzeis now build is green. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants