-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.2-develop] Add static test to detect blocks without name attribute #11235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run all static tests on Travis (cherry picked from commit 117287f)
(cherry picked from commit b0f5a66)
Fix static test failures (cherry picked from commit e57ef72)
(cherry picked from commit 2e70f00)
Add names to blocks in layout XML `catalog_product_view_type_grouped.xml` to make them accessible (cherry picked from commit a4edec7)
(cherry picked from commit 50105b4)
… to be able to extend them using referenceBlock functionality (cherry picked from commit d2a37e4)
ihor-sviziev
changed the title
Add static test to detect blocks without name attribute
[2.2-develop] Add static test to detect blocks without name attribute
Oct 5, 2017
The functional test suite timed out. I'll close and re-open the PR to trigger a new build. |
@mzeis now build is green. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change covers an issue when block doesn't contain name attribute in layout file.
As was discussed in #10354 (comment) - need to covert missing block names issue with static test.
Fixed Issues (if relevant)
Related issues
Manual testing scenarios
Contribution checklist