Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a cache.xml entry for compiled_config cache #11296

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Oct 8, 2017

Description

Provide a cache.xml entry for compiled_config cache.
This seems to be missing as it is the only subclass of \Magento\Framework\Cache\Frontend\Decorator\TagScope that does not appear in any cache.xml file.

Fixed Issues (if relevant)

  1. The following requested cache types are not supported: 'compiled_config'. #11295: The following requested cache types are not supported: 'compiled_config'.

Manual testing scenarios

  1. Run bin/magento cache:enable compiled_config
  2. See
               compiled_config: 0 -> 1
Cleaned cache types:
compiled_config

instead of

  [InvalidArgumentException]
  The following requested cache types are not supported: 'compiled_config'.
  Supported types: config, layout, block_html, collections, reflection, db_ddl, eav, customer_notification, translate, target_rule, full_page, config_integration, config_integration_api, config_webservice



cache:enable [--bootstrap="..."] [types1] ... [typesN]

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This seems to be missing as it is the only subclass of `\Magento\Framework\Cache\Frontend\Decorator\TagScope` that does not appear in any `cache.xml` file.

Fixes magento#11295
@dmanners dmanners self-assigned this Oct 9, 2017
@dmanners dmanners added this to the October 2017 milestone Oct 9, 2017
@dmanners
Copy link
Contributor

dmanners commented Oct 9, 2017

Hi @ajpevers, thank you for this PR. I will pick this up and start to process it for you. If I need any further information I will contact you.

@AntonEvers
Copy link
Contributor Author

Perfect, thanks @dmanners 👍

@dmanners
Copy link
Contributor

dmanners commented Oct 9, 2017

@ajpevers would be good to include the text into the app/code/Magento/Store/i18n/en_US.csv with all the other config labels etc.

@AntonEvers
Copy link
Contributor Author

@dmanners sure, no problem.

Copy link
Contributor

@dmanners dmanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I will run this through the internal tools.

@magento-team magento-team merged commit d81b9f2 into magento:develop Oct 12, 2017
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this pull request Oct 21, 2017
@AntonEvers AntonEvers mentioned this pull request Oct 21, 2017
4 tasks
@keharper keharper mentioned this pull request Jun 8, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants