Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes mass action in catalog/product grid can not proceed #11335

Closed
wants to merge 4 commits into from
Closed

Update attributes mass action in catalog/product grid can not proceed #11335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b47b098
MassAction fix
manuelson Oct 10, 2017
1b82c32
Fix unit test
manuelson Oct 10, 2017
8ecaa74
Refactoring code
manuelson Oct 10, 2017
4a7758f
Code style From unit test
manuelson Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/Data/Form/Element/Multiselect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function getElementHtml()
$this->addClass('select multiselect admin__control-multiselect');
$html = '';
if ($this->getCanBeEmpty()) {
$html .= '<input type="hidden" name="' . parent::getName() . '" value="" />';
$html .= '<input type="hidden" id="' . $this->getHtmlId() . '_hidden" name="' . parent::getName() . '" value="" />';
}
if (!empty($this->_data['disabled'])) {
$html .= '<input type="hidden" name="' . parent::getName() . '_disabled" value="" />';
Expand Down
6 changes: 5 additions & 1 deletion lib/internal/Magento/Framework/Data/Test/Unit/Form/Element/MultiselectTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,14 @@ protected function setUp()
public function testHiddenFieldPresentInMultiSelect()
{
$fieldName = 'fieldName';
$fieldId = 'fieldId';
$this->_model->setCanBeEmpty(true);
$this->_model->setName($fieldName);
$this->_model->setId($fieldId);
$elementHtml = $this->_model->getElementHtml();
$this->assertContains('<input type="hidden" name="' . $fieldName . '"', $elementHtml);
$this->assertContains(
'<input type="hidden" id="' . $fieldId . '_hidden" name="' . $fieldName . '"', $elementHtml
);
}

/**
Expand Down