PHP Livecodetest testCodeStyle() method does not use whitelist files

[adrian-martinez-interactiv4]

Description

\Magento\Test\Php\LiveCodeTest::testCodeStyle method does not use whitelist files, as it does \Magento\Test\Php\LiveCodeTest::testCodeMess. Because of that, it takes ages to complete when you only want to test code style for a few modified files.

With proposed changes, it will try to find whitelisted files, and if it does not find any, then full whitelist will be checked. By default the behaviour is the same, as long as you have the ability to limit processed files if you create whitelist files from outside.

Fixed Issues (if relevant)

Improvement

Manual testing scenarios

1. Create (manually, via git diff, via get_github_changes.php script) Magento/Test/_files/changed_files_local.txt, with references to real modified files to be tested.
2. Run vendor/bin/phpunit --verbose -c dev/tests/static/phpunit-all.xml.dist.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[orlangur]

It was done intentionally in #8685 and should not be ever changed in order to avoid regression of fixed problem. PHPCS run takes only few minutes while PHPMD would take hours.

Behavior of $changedFiles = self::getChangedFilesList($changedFilesBaseDir); can be slightly changed in your particular project if current one does not work well.

[orlangur]

Current implementation needs to be changed so that:

• 100% whitelisted files check is preserved on any CI
• it is possible to run a reduced check locally

[orlangur]

I suggest changing it to testcodestyle.is_full_scan and default 1 value.

I'm not sure whether it's better to use env or const, like we do in integration tests <const name="TESTS_CLEANUP" value="enabled"/>.

[orlangur]

Simply $whitelist = !empty(...is_full_scan...) ? ...

Please use both php and phtml.

[adrian-martinez-interactiv4]

@vrann I updated this PR to include new const also in phpunit-all.xml.dist file, and add comments, could you check the commit associated to this PR? 205c2f9

The one added in MAGETWO-81646 - bf50355 does not include the last changes, and due to this, conflicts have raised: https://github.com/magento/magento2/pull/11362/conflicts.

[orlangur]

@adrian-martinez-interactiv4 it cannot be reverted, please apply these additional changes on top of new develop and force push to the same branch.

[adrian-martinez-interactiv4]

@orlangur Done

[orlangur]

@adrian-martinez-interactiv4

Magento\Test\Php\LiveCodeTest::testCodeStyle
PHPUnit\Framework\Exception: Warning: file_get_contents(.../magento2/dev/tests/static/report/phpcs_report.txt): failed to open stream: No such file or directory in .../magento2/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php:212.

...1/magento2/dev/tests/static/framework/bootstrap.php:56
.../magento2/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php:212

Somehow it is not passing on Bamboo currently, I need some time to find out why. No action required from your side, just some patience :)

[ihor-sviziev]

@orlangur it looks like after f59cfe2 issue should gone away. Could you re-check?

[orlangur]

@ihor-sviziev it is just a workaround, I need to find out how such changes broke the Bamboo CICD loop.