Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10856: Sync billing with shipping address on Admin Order Page #11385

Merged
merged 4 commits into from
Oct 24, 2017
Merged

Fix #10856: Sync billing with shipping address on Admin Order Page #11385

merged 4 commits into from
Oct 24, 2017

Conversation

joni-jones
Copy link
Contributor

@joni-jones joni-jones commented Oct 11, 2017 •
edited by fooman
Loading

Fixed Issues

  1. Sync billing with shipping address on Admin Reorder and Admin Customer Create Order page does not work for Existing address selected #10856: Sync billing with shipping address on Admin Reorder and Admin Customer Create Order page does not work for Existing address selected

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@joni-jones
Sync billing with shipping address on Admin Order Page
1743a36 
 - Set customer address ID only if the address was selected in dropdown
 - Removed "old" billing address from quote if customer address doesn't specified
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 11, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this Oct 11, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 11, 2017
@joni-jones
Sync billing with shipping address on Admin Order Page
63b549b 
 - Added validation for empty applied taxes to avoid exceptions during json decoding
@joni-jones
Copy link
Contributor Author

@magento-team, I see needs update label, any questions about this PR?

@joni-jones
Sync billing with shipping address on Admin Order Page
b1a0181 
 - Fixed skipped 'Same as billing' checkbox
@okorshenko okorshenko merged commit b1a0181 into magento:2.2-develop Oct 24, 2017
okorshenko pushed a commit that referenced this pull request Oct 24, 2017
MAGETWO-81680: Fix #10856: Sync billing with shipping address on Admi…
4d613f2 
…n Order Page #11385
@joni-jones joni-jones deleted the G#10856 branch July 2, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Release Line: 2.2
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@joni-jones @magento-cicd2 @magento-team @okorshenko