Attribute category_ids issue #11389

manuelson · 2017-10-11T20:40:14Z

Description

Attribute category_ids issue

Fixed Issues

Attribute category_ids issue #11341: Attribute category_ids issue

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

orlangur

After all changes are made and all builds but functional tests are green on Travis, please squash changes into a single commit.

orlangur · 2017-10-12T06:11:31Z

app/code/Magento/Catalog/Block/Product/View/Attributes.php

-                } elseif ($attribute->getFrontendInput() == 'price' && is_string($value)) {
-                    $value = $this->priceCurrency->convertAndFormat($value);
-                }
+                if(!is_array($value)) {


Please do not increase indentation, change to

if (is_array($value)) { continue; }

orlangur · 2017-10-12T06:11:57Z

app/code/Magento/Catalog/Block/Product/View/Attributes.php

+                if(!is_array($value)) {
+                    if (!$product->hasData($attribute->getAttributeCode())) {
+                        $value = __('N/A');
+                    } elseif (is_array($value)) {


This seems to be always false condition, please remove.

orlangur · 2017-10-12T10:02:05Z

app/code/Magento/Catalog/Block/Product/View/Attributes.php

                if (!$product->hasData($attribute->getAttributeCode())) {
                    $value = __('N/A');
+                } elseif (is_array($value)) {
+                    continue;


No-no, your initial idea with skipping everything in case of array was fine, continue here is a bit confusing.

Please move it upper:

if (is_array($value = $attribute->getFrontend()->getValue($product))) { continue; }

and the rest will remain the same. Please squash changes into single commit when builds are green (you can ignore functional tests on Travis, they are failing sometimes due to timeouts).

manuelson

Fix it

manuelson · 2017-10-13T11:55:24Z

app/code/Magento/Catalog/Block/Product/View/Attributes.php

                if (!$product->hasData($attribute->getAttributeCode())) {
                    $value = __('N/A');
+                } elseif (is_array($value)) {
+                    continue;


orlangur · 2017-10-13T12:06:17Z

@manuelson thanks, changes look good to me now and builds on Travis are passing.

Could you please squash all changes into a single commit? I may assist with this if needed.

manuelson · 2017-10-13T12:17:37Z

@orlangur did You mean that I have to close this PR and open a new one with a single commit?

orlangur · 2017-10-13T12:27:07Z

No, just force push into the same branch.

Fixed issue: MAGETWO-77777 [2.2.x] - [Magento Cloud] Using search synonyms from the same group gives different results array bug fix Category_ids display no Refactoring continue condition Condition rewrite

manuelson · 2017-10-13T12:41:44Z

Done

manuelson · 2017-10-27T11:08:58Z

@orlangur @okobchenko @vkublytskyi can be SQUASHTOBERFEST? :)

orlangur · 2017-10-27T11:11:54Z

@manuelson not sure who defines it, not me :(

manuelson · 2017-11-08T12:00:18Z

Hello @orlangur for close it , you need any update?

Thanks!

orlangur · 2017-11-08T14:44:25Z

Hi @manuelson, no update needed, I believe it's still waiting for testing

magento-team moved this from Review In Progress to Testing In Progress in Community Pull Requests 22 days ago

- Merge Pull Request #11807 from manuelson/magento2:feature/11341_backport - Merged commits: 1. 4e24f73

@manuelson

Public Pull Requests #11807 [backport 2.1] Attribute category_ids issue #11389 by @manuelson Fixed Public Issues #11341 Attribute category_ids issue

orlangur self-assigned this Oct 12, 2017

orlangur requested changes Oct 12, 2017

View reviewed changes

orlangur added the Progress: needs update label Oct 12, 2017

orlangur requested changes Oct 12, 2017

View reviewed changes

manuelson commented Oct 13, 2017

View reviewed changes

orlangur added this to the October 2017 milestone Oct 13, 2017

orlangur added the Release Line: 2.2 label Oct 13, 2017

orlangur added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 13, 2017

Merge pull request magento#1577 from magento-panda/PANDA-FIXES-2.2

c33d9d7

Fixed issue: MAGETWO-77777 [2.2.x] - [Magento Cloud] Using search synonyms from the same group gives different results array bug fix Category_ids display no Refactoring continue condition Condition rewrite

manuelson force-pushed the feature/11341 branch from eec39a4 to c33d9d7 Compare October 13, 2017 12:37

orlangur removed the Progress: needs update label Oct 13, 2017

orlangur approved these changes Oct 13, 2017

View reviewed changes

vkublytskyi added the partner contribution label Oct 19, 2017

This was referenced Oct 27, 2017

[backport 2.1] Attribute category_ids issue #11389 #11807

Merged

[backport 2.3] Attribute category_ids issue #11389 #11811

Closed

okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017

magento-engcom-team added Reproduced on develop labels Nov 7, 2017

okorshenko removed the Reproduced on develop label Nov 7, 2017

magento-engcom-team added the Reproduced on develop label Nov 8, 2017

okorshenko removed the Reproduced on develop label Nov 8, 2017

magento-engcom-team added the Reproduced on develop label Nov 8, 2017

magento-team added the Progress: needs update label Nov 8, 2017

magento-team added Progress: accept and removed Progress: needs update labels Nov 27, 2017

okorshenko merged commit c33d9d7 into magento:2.2-develop Nov 28, 2017

okorshenko pushed a commit that referenced this pull request Nov 28, 2017

MAGETWO-81916: Attribute category_ids issue #11389

a0a2474

magento-team pushed a commit that referenced this pull request Nov 30, 2017

MAGETWO-84688: [backport 2.1] Attribute category_ids issue #11389 #11807

598ecd5

- Merge Pull Request #11807 from manuelson/magento2:feature/11341_backport - Merged commits: 1. 4e24f73

magento-team pushed a commit that referenced this pull request Nov 30, 2017

MAGETWO-84688: [backport 2.1] Attribute category_ids issue #11389 #11807

f90a91a

magento-team pushed a commit that referenced this pull request Nov 30, 2017

Merge pull request #1775 from magento-engcom/2.1-develop-prs

bf06306

Public Pull Requests #11807 [backport 2.1] Attribute category_ids issue #11389 by @manuelson Fixed Public Issues #11341 Attribute category_ids issue

vkublytskyi added the port-to-2.3 label Jan 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attribute category_ids issue #11389

Attribute category_ids issue #11389

manuelson commented Oct 11, 2017

orlangur left a comment

orlangur Oct 12, 2017

orlangur Oct 12, 2017

orlangur Oct 12, 2017

manuelson Oct 13, 2017

manuelson left a comment

manuelson Oct 13, 2017

orlangur commented Oct 13, 2017

manuelson commented Oct 13, 2017

orlangur commented Oct 13, 2017

manuelson commented Oct 13, 2017

manuelson commented Oct 27, 2017 •

edited

Loading

orlangur commented Oct 27, 2017

manuelson commented Nov 8, 2017

orlangur commented Nov 8, 2017

Attribute category_ids issue #11389

Attribute category_ids issue #11389

Conversation

manuelson commented Oct 11, 2017

Description

Fixed Issues

Contribution checklist

orlangur left a comment

Choose a reason for hiding this comment

orlangur Oct 12, 2017

Choose a reason for hiding this comment

orlangur Oct 12, 2017

Choose a reason for hiding this comment

orlangur Oct 12, 2017

Choose a reason for hiding this comment

manuelson Oct 13, 2017

Choose a reason for hiding this comment

manuelson left a comment

Choose a reason for hiding this comment

manuelson Oct 13, 2017

Choose a reason for hiding this comment

orlangur commented Oct 13, 2017

manuelson commented Oct 13, 2017

orlangur commented Oct 13, 2017

manuelson commented Oct 13, 2017

manuelson commented Oct 27, 2017 • edited Loading

orlangur commented Oct 27, 2017

manuelson commented Nov 8, 2017

orlangur commented Nov 8, 2017

manuelson commented Oct 27, 2017 •

edited

Loading