Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added carrier code to ID to distinguish shipping methods #11406

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

peterjaap
Copy link
Contributor

@peterjaap peterjaap commented Oct 12, 2017

Added carrier code to ID to distinguish shipping methods with the same method name but differing carrier code

Shipping method radios have duplicate element IDs on cart page, which makes it impossible to select the second method.

Description

Make the element ID unique by adding in the carrier code into the ID.

Fixed Issues (if relevant)

  1. Shipping method radios have duplicate IDs on cart page #10795: Shipping method radios have duplicate IDs on cart page

Manual testing scenarios

  1. Create a shipping method with a unique carrier name but a method name that is in use, such as 'freeshipping' (make sure to of course enable the freeshipping option and have it appear in the checklist).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 12, 2017

CLA assistant check
All committers have signed the CLA.

@miguelbalparda
Copy link
Contributor

All good here, this is going to be merged soon. @peterjaap can you please port this fix to 2.1 and 2.3? Thanks for your contribution!

@peterjaap
Copy link
Contributor Author

@miguelbalparda how do we handle a port? Do you want separate PR's for the cherry-picked commit for the 2.1-develop and 2.3-develop branches?

@peterjaap
Copy link
Contributor Author

peterjaap commented Oct 14, 2017

Apparently, yes. I've created those;

#11456 (backport 2.1)
#11457 (forwardport 2.3)

@okorshenko okorshenko merged commit e2f23bd into magento:2.2-develop Oct 16, 2017
@peterjaap peterjaap deleted the fix-for-issue-10795 branch October 17, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants