Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolbar-amount placing in mobile device #11430

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

slackerzz
Copy link
Member

The toolbar amount element is misplaced because of a position: absolute

Description

Fixed Issues (if relevant)

  1. Responsive Design Issue on Mobile with Magento 2.1.9 #10941: Responsive Design Issue on Mobile with Magento 2.1.9

Manual testing scenarios

  1. Create a cms page with this content:
{{widget type="Magento\Catalog\Block\Product\Widget\NewWidget" display_type="all_products" show_pager="1" products_per_page="4" products_count="16" template="product/widget/new/content/new_grid.phtml" page_var_name="pipexq"}}
{{widget type="Magento\Catalog\Block\Widget\RecentlyViewed" uiComponent="widget_recently_viewed" page_size="4" show_attributes="name,image,price" show_buttons="add_to_cart,add_to_compare,add_to_wishlist" template="product/widget/viewed/grid.phtml"}}

Before the result was:
m2dev local-test-catalog nexus 5

After the fix the result is:
m2dev local-test-catalog nexus 5 2

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 16, 2017
@okorshenko okorshenko added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 16, 2017
@okorshenko okorshenko merged commit 3548000 into magento:2.2-develop Oct 16, 2017
@slackerzz slackerzz deleted the fix_issue_10941 branch October 18, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants