Issue #11428: Cart Price Rule Label is not working

[mrodespin]

Description

Cart Price Rule Label is not working. The Total label for discounts was not the correct one, after this fix the label was "Discount" and with this change is the Cart Rule Label.

Steps to reproduce

1. While creating the cart price rule, I have given the Label value as "Buy 2 and Get 1 Free".
2. In front end, Checkout page, It will show only the label as "Discount" not the given name has been reflected.

Fixed Issues (if relevant)

The following modification fixes this magento 2 issue #11428

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[adrian-martinez-interactiv4]

I leave here a reference to the related issue: #11428

[ghost]

We have tested with this solution it's working but it's displayed "Discount" Before label. I think It's should not be display If a label is set. @mrodespin Please consider covering the updated flow with the test.

[mrodespin]

@emiprotech I didn't remove the Discount label because it how it works in previous magento versions.

[mrodespin]

@magento-team i seen than you added a needs update label, but i don't know why. What i have to modify??

[okorshenko]

Hi @mrodespin we are trying to align your solution with the documentation http://docs.magento.com/m2/ce/user_guide/marketing/price-rules-cart.html

[mrodespin]

@okorshenko ok i will wait then. Can you add the partner contribution label to my PRs?

[okorshenko]

Hi @mrodespin, unfortunately, we can not accept this changes. Please see the comment here: #11428 (comment)

[pmoreno1980]

@okobchenko here we have 2 situations for this issue (Cart Price Rule Label is not working):

Shopping Cart Rules with Coupon Code and this is the solution for that #6244

Shopping Cart Rules without Coupon Code, i mean automatic discount, we don't have solution for this yet, this #11438 doesn't work.

this is a very important problem that is not solved in Magento 2. we didn't have this issue on Magento 1

thanks for you help

[pmoreno1980]

any update here? its a big bug, i know that is fixed on enterprise version.

please let me know

[versdivers]

I have the same issue. Filled in all the labels. Frontend just says 'Discount'

[soniclouds]

Any updates on this??? Using 2.4.2 Commerce and same exact issue. Labels not working when applying cart rule without coupon code. If not label, we should at least be able to get the rule name, but this doesn't even seem to be available.