[Backport 2.2-develop] #11328 : app:config:dump adds extra space every time in multiline array value #11439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-martinez-interactiv4
changed the title
|
@adrian-martinez-interactiv4 I see two additional commits on #11451 (2.1-develop version of this). Can you replay those onto this PR as well? |
davidalger
added
Release Line: 2.2
2.2.x
Reproduced on 2.2.x
|
@davidalger I'll check this |
|
@davidalger Some changes only applied to 2.1 version, that's why it has more commits than 2.2 and develop PRs. Anyway, I have checked changed files for differences, and I have unified the code between all versions in last added commit. This should be ready for review. |
davidalger
approved these changes
Oct 20, 2017
This was referenced Oct 20, 2017
okorshenko
pushed a commit
that referenced
this pull request
Oct 24, 2017
…xtra space every time in multiline array value #11439
okorshenko
added
bug report
Reproduced on 2.1.x
okorshenko
pushed a commit
that referenced
this pull request
Oct 24, 2017
…xtra space every time in multiline array value #11439
adrian-martinez-interactiv4
deleted the
FR22#11328-APP-CONFIG-DUMP-EXTRA-SPACES
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
app:config:dump adds extra space every time in multiline array value
Description
Rewrite PhpFormatter::format method, to avoid add extra spaces
Fixed Issues (if relevant)
Manual testing scenarios
Described in issue #11328
Contribution checklist