Add missing translations in Magento_UI

[JeroenVanLeusden]

Description

Add missing translations in UI module taken from mage/validation.js file.

Fixed Issues (if relevant)

1. Untranslatable string "Please enter the same value again." #5956: Untranslatable string "Please enter the same value again."

Manual testing scenarios

1. Install dutch language pack.
2. Set locale of frontend to dutch.
3. Create new user on the storefront, Fill both password fields with a different value.
4. String should be translated.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[fooman]

@JeroenVanLeusden thanks for this pull request. I am currently unable to confirm that this patch does indeed fix the issue.

Couple of questions:

1. Are there any other steps needed to verify the translations works?
   I have used honl/magento2-nl-nl (which didn't seem to include this term so I added a dummy translation) and run bin/magento clear:cache and have also wiped the pub/static content in developer mode, but am still seeing:

2. Is there a reason that this added to the UI module? It seems that at least the string
   "Please enter the same value again." is already present here.

[fooman]

I have now tested in production mode which successfully translated
"Please enter the same value again."
for me. However this was without the changes of this PR applied.

[JeroenVanLeusden]

@fooman Even in production the mode the string isn't translated. Could it be your dummy translations you've added earlier in the process?

I did the following steps to reproduce the issue:

• composer require honl/magento2-nl-nl
• Create file src/lib/web/i18n/nl_NL.csv and add "Please enter the same value again.","Vul dezelfde waarde nog een keer in."
• php bin/magento setup:static-content:deploy nl_NL -j 1 -f
• In src/pub/static/frontend/Magento/luma/nl_NL/js-translation.json the string isn’t translated.
• In src/app/code/Magento/Ui/i18n/nl_NL.csv add "Please enter the same value again.","Vul dezelfde waarde nog een keer in, Magento_UI"
• php bin/magento setup:static-content:deploy nl_NL -j 1 -f
• In src/pub/static/frontend/Magento/luma/nl_NL/js-translation.json the string is translated with the Magento_UI prefix.

I added them to Magento_UI since most translations from mage/validation.js are located there. The strings located here are not used at all.

[fooman]

@JeroenVanLeusden can you try the following on your end:

• composer require honl/magento2-nl-nl
• add
  "Please enter the same value again.","Vul dezelfde waarde nog een keer in.",module,Magento_Ui to vendor/honl/magento2-nl-nl/crowdin.csv
• then run bin/magento setup:static-content:deploy nl_NL en_US -j 1 -f

After the above I get the below

I do believe there is still some oddity somewhere (possibly in the quick deploy strategy) as just running bin/magento setup:static-content:deploy nl_NL -j 1 -f did not work.

[JeroenVanLeusden]

@fooman Following your steps resulted in a translated string. Running bin/magento setup:static-content:deploy nl_NL -j 1 -f wil also translate the string in my case. So far so good.

I decided to add them to Magento_UI because php bin/magento i18n:collect-phrases -o "strings.csv" -m collects the string as "Please enter the same value again.","Please enter the same value again.",lib,lib/web/mage/validation.js and when adding that to vendor/honl/magento2-nl-nl/crowdin.csv it results in a non translated string.

[fooman]

Thanks @JeroenVanLeusden for confirming. So this narrows it down to there being an issue with either the output of collect-phrases not being correct or lib,lib/web/mage/validation.js not working correctly when applied.

For now your suggested approach seems a reasonable workaround considering that this seems to have already been done in the past. I'll proceed with merging this one - however can you please take a look at line 203.

[fooman]

"Please enter a value between {0} and {1}." Misses second part and quotes

[JeroenVanLeusden]

@fooman Thanks for the update. I also corrected line 203.