Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR#5768_21 Magento 2.0.7 XML sitemap is not generated by schedule [Backport 2.1 develop] #11476

Closed
wants to merge 5 commits into from

Conversation

mrodespin
Copy link
Contributor

@mrodespin mrodespin commented Oct 15, 2017

Magento 2 sitemap generation frequency configuration was not working. When a administrator wants to enable the functionality of automatic sitemap generation the frequency was not saving in cron_schedule table.

Description

The commit solves the issue on saving magento 2 automatic sitemap generation configuration. With these modifications the cron job is working properly.

Manual testing scenarios

  1. go to admin>store>configurtion>catalog>xml sitemap
  2. turn on generation and set up time.
  3. Execute php bin/magento cron:run
  4. Go to cron_schedule table and the cron job sitemap_generate is not in the table

With this modification if we do the same process the cron job appears in the table (If the time configured is nearby)

Related PRs:

#11474

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mrodespin mrodespin closed this Oct 15, 2017
@mrodespin mrodespin deleted the FR#5768_21 branch October 15, 2017 20:21
@mrodespin mrodespin restored the FR#5768_21 branch October 15, 2017 20:25
@dmanners
Copy link
Contributor

dmanners commented Nov 6, 2017

This is the same as #11475 the change does not fix an issue but is only changing of code styles.

@dmanners dmanners closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants