Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "optional" translation in checkout password field #11493

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

JeroenVanLeusden
Copy link
Member

Description

Original PR #10056.

Translatable placeholder is added in the template but not the .csv file.

Fixed Issues (if relevant)

  1. None that I could find.

Manual testing scenarios

  1. Install non English language pack.
  2. Open Guest Mode browsing.
  3. Go to checkout.
  4. Enter the email address of a customer which already exists.
  5. Placeholder is not translated.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 16, 2017
@okorshenko okorshenko merged commit 221c593 into magento:2.2-develop Oct 16, 2017
@JeroenVanLeusden JeroenVanLeusden deleted the patch-7 branch October 17, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants