-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Modify Report processor to return 500 #11513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Report processor to return 500 #11513
Conversation
The report processor is currently returning a HTTP 503 status code; generally used for temporarily failures to connect to a service such as when that service is in maintenance mode, when an upstream proxy is unavailable etc. This commit modifies the report HTTP code to be a 500. The author believes this to be a better reflection that the error is miscellaneous in nature, and that action is required in order to change it (i.e. it is not a temporary condition)
|
CI failed due to timeout. Please rerun |
|
Yeah, simply ignore it, main source of truth is Bamboo running internally. |
|
While I understand that, I do feel I need to point out that if CI is ignored, it is pointless. I am somewhat grossly passionate about this topic as I find people regularly ignoring builds, but I feel it's reasonable to point this out here. Or, in other words, old man grumbling |
|
Sorry, I didn't give enough context (as usual), I'm a big fan of CICD done the right way as well :) I meant "ignore functional tests in Travis, I hope somebody is working on permanent solution for these failures". Just found out if was fixed for |
|
HAHA sweet. I sometimes feel guilty for bitching, but unfortunately someone has to and I am okay being the jerk. <3 for patience, and particularly <3 for super fast feedback. This is my first PR, and it's cool! |
|
Uhh @magento-team what needs an update? And @okorshenko I'm hesitant to call this a feature request as:
Please advise |
|
Hello @andrewhowdencom, the only problem here was an actual issue reproduction to see 500/503 HTTP code. I will check it today and I believe we will proceed with merging. Don't worry about labels, all PRs are processed manually and won't get closed accidentally. Probably related to some massive issue processing. |
The report processor is currently returning a HTTP 503 status
code; generally used for temporarily failures to connect to a service
such as when that service is in maintenance mode, when an upstream
proxy is unavailable etc.
This commit modifies the report HTTP code to be a 500. The author
believes this to be a better reflection that the error is miscellaneous
in nature, and that action is required in order to change it (i.e.
it is not a temporary condition)
Fixes #11512