Skip to content

Conversation

@andrewhowdencom
Copy link
Contributor

The report processor is currently returning a HTTP 503 status
code; generally used for temporarily failures to connect to a service
such as when that service is in maintenance mode, when an upstream
proxy is unavailable etc.

This commit modifies the report HTTP code to be a 500. The author
believes this to be a better reflection that the error is miscellaneous
in nature, and that action is required in order to change it (i.e.
it is not a temporary condition)

Fixes #11512

The report processor is currently returning a HTTP 503 status
code; generally used for temporarily failures to connect to a service
such as when that service is in maintenance mode, when an upstream
proxy is unavailable etc.

This commit modifies the report HTTP code to be a 500. The author
believes this to be a better reflection that the error is miscellaneous
in nature, and that action is required in order to change it (i.e.
it is not a temporary condition)
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 17, 2017

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Oct 17, 2017
@orlangur orlangur added this to the October 2017 milestone Oct 17, 2017
@andrewhowdencom
Copy link
Contributor Author

CI failed due to timeout. Please rerun

@orlangur
Copy link
Contributor

Yeah, simply ignore it, main source of truth is Bamboo running internally.

@andrewhowdencom
Copy link
Contributor Author

While I understand that, I do feel I need to point out that if CI is ignored, it is pointless. I am somewhat grossly passionate about this topic as I find people regularly ignoring builds, but I feel it's reasonable to point this out here.

Or, in other words, old man grumbling

@orlangur
Copy link
Contributor

orlangur commented Oct 18, 2017

Sorry, I didn't give enough context (as usual), I'm a big fan of CICD done the right way as well :)

I meant "ignore functional tests in Travis, I hope somebody is working on permanent solution for these failures". Just found out if was fixed for develop in f291ca3#diff-354f30a63fb0907d4ad57269548329e3 (by testsuite reduction but it's totally fine considering limited Travis resources and that those tests are still running on Bamboo). Raised this problem in Slack so that it will be backported to 2.1-develop and 2.2-develop (or maybe fixed another way).

@andrewhowdencom
Copy link
Contributor Author

HAHA sweet. I sometimes feel guilty for bitching, but unfortunately someone has to and I am okay being the jerk.

<3 for patience, and particularly <3 for super fast feedback. This is my first PR, and it's cool!

@andrewhowdencom
Copy link
Contributor Author

Uhh @magento-team what needs an update? And @okorshenko I'm hesitant to call this a feature request as:

  • it's changing behaviour, not adding new functionality. That's at most a refactoring, but not a feature request
  • feature requests are a disallowed here, and are often closed.

Please advise

@orlangur
Copy link
Contributor

Hello @andrewhowdencom, the only problem here was an actual issue reproduction to see 500/503 HTTP code. I will check it today and I believe we will proceed with merging.

Don't worry about labels, all PRs are processed manually and won't get closed accidentally. Probably related to some massive issue processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants