Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6802: Magento\Search\Helper\getSuggestUrl() not used in search template. #11722

Merged
merged 1 commit into from
Nov 9, 2017
Merged

6802: Magento\Search\Helper\getSuggestUrl() not used in search template. #11722

merged 1 commit into from
Nov 9, 2017

Conversation

nmalevanec
Copy link
Contributor

Description

Magento\Search\Helper\Data::getSuggestUrl() now used in form.mini.phtml instead of direct call on $block->getUrl().

Fixed Issues (if relevant)

  1. Magento\Search\Helper\getSuggestUrl() not used in search template #6802: Magento\Search\Helper\getSuggestUrl() not used in search template

Manual testing scenarios

  1. Create a plugin for Magento\Search\Helper\Data::getSuggestUrl() with method afterGetSuggestUrl() to add custom autosuggest feature(or use just return 'some-test-url-which-leads-nowhere').
  2. Type something in the search box.
  3. the custom URL should be used(check console, if you use 'some-test-url-which-leads-nowhere'. You should see 404 error with your test url with query params).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Oct 27, 2017
@dmanners dmanners added this to the October 2017 milestone Oct 27, 2017
@dmanners dmanners added Release Line: 2.2 2.2.x bug report Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Search labels Oct 27, 2017
@nmalevanec nmalevanec changed the title MAGETWO-6802: Magento\Search\Helper\getSuggestUrl() not used in search template. 6802: Magento\Search\Helper\getSuggestUrl() not used in search template. Oct 27, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit 751143b into magento:2.2-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
@nmalevanec nmalevanec deleted the MAGETWO-6802 branch August 21, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report bugfix Component: Search Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants