Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGETWO-5015: Report error csv doesn't work when trying to import a csv file with semicolon delimiter. #11732

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

p-bystritsky
Copy link
Contributor

Description

Product import error report taking into consideration value delimiter.

Fixed Issues (if relevant)

  1. Report error csv doesn't work when trying to import a csv file with semicolon delimiter #5015: Report error csv doesn't work when trying to import a csv file with semicolon delimiter

Manual testing scenarios

  1. Try to import a catalog_product.csv file in admin interface which contains an error (try to insert incorrect visibility field value, for example 'cathaloig').
  2. Configure the semicolon (';') for row delimiter.
  3. Click Check data button, the file is valid for import.
  4. You should be able to download the report error csv file.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 25, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 28, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 28, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x bug report Component: ImportExport Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 28, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit 1683995 into magento:2.2-develop Nov 1, 2017
okorshenko pushed a commit that referenced this pull request Nov 1, 2017
…g to import a csv file with semicolon delimiter. #11732
This was referenced Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: ImportExport Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants