[Backport 2.1-develop] Remove hardcoding for Magento_Backend::admin in ACL tree #11739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @paliarush who was assigned to the original ticket |
navarr
changed the title
This backports a removal of the hardcoding the array index of Magento_Backend::admin in the resources ACL tree Original commit 66d1960
|
@navarr thanks for this PR. Is there a set of testing steps someplace for this fix? |
|
Not straightforward but yes. If you create a module that has an ACL tree starting with Magento_Adminhtml (instead of Magento_Backend), then edit or create a role - the tree will be empty. After this patch, the tree will appear. I had the original PR in the title but changed the title - that would be #4396 |
|
Thanks @navarr will try to process this for you. |
dmanners
approved these changes
Oct 31, 2017
magento-team
added
Progress: needs update
Progress: accept
and removed
Progress: needs update
labels
okorshenko
pushed a commit
that referenced
this pull request
Nov 9, 2017
…ackend::admin in ACL tree #11739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports a removal of the hardcoding the array index of
Magento_Backend::admin in the resources ACL tree
Original commit 66d1960