Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2-develop] Fix label to avoid wrapping poorly,now break by word #11745

Merged

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Oct 25, 2017

Description

Backport to 2.2 of PR: " Fix: field labels wrapping poorly #11727 "
Some long labels break by letter, that was a UX problem to some users and confusiing. I've edited a styless-old.less to fix it.

Fixed Issues (if relevant)

Admin: field labels wrapping poorly #7099

Manual testing scenarios

  1. Go to any page that has long input field labels, such as when adding a new product attribute (also depends of your resolution)
  2. Now the labels break by word instead by letter.

BEFORE:
screen shot 2017-10-25 at 15 56 23
NOW:
screen shot 2017-10-25 at 16 02 35

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this Oct 25, 2017
@enriquei4 enriquei4 changed the title Fix label to avoid wrapping poorly,now break by word [Backport 2.2] [Backport 2.2-develop] Fix label to avoid wrapping poorly,now break by word Oct 25, 2017
@miguelbalparda miguelbalparda added this to the October 2017 milestone Oct 26, 2017
@okorshenko okorshenko merged commit 6e25ab3 into magento:2.2-develop Oct 27, 2017
okorshenko pushed a commit that referenced this pull request Oct 27, 2017
@enriquei4 enriquei4 deleted the FIX-ADMIN-FIELD-BREAK-LABELS-2-2 branch October 27, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants