Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2-develop] Fix datetime type product that show current date when is empty in grids #11749

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Oct 25, 2017

Description

Backport of PR: Fix datetime type product that show current date when is empty in grids #11636

In the product grid, when a date attribute is listed and the value was empty, the current date was displayed. This was very confusing because I did not know if the value was assigned or not. Now you can see empty cells when is unassigned.

Fixed Issues (if relevant)

datetime type product attribute showing current date #9869

Manual testing scenarios

  1. Create a date type product attribute
  2. assign that product to the required attribute set
  3. you can edit the attribute value in the product edit.
  4. create a new product and simply not assign any value to this attribute.
  5. save product
  6. Now you dont see the current date if is unset.

NOW:
screen shot 2017-10-24 at 08 55 38

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • [] All automated tests passed successfully (all builds on Travis CI are green)

@enriquei4 enriquei4 changed the title Fix datetime type product that show current date when is empty in grids [Backport 2.2] [Backport 2.2-develop] Fix datetime type product that show current date when is empty in grids Oct 25, 2017
@miguelbalparda miguelbalparda self-assigned this Oct 26, 2017
@miguelbalparda miguelbalparda added this to the October 2017 milestone Oct 26, 2017
@okorshenko okorshenko merged commit bb3fae9 into magento:2.2-develop Oct 27, 2017
okorshenko pushed a commit that referenced this pull request Oct 27, 2017
@enriquei4 enriquei4 deleted the DONT-SHOW-UNSETDATE branch October 29, 2017 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants