Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6948: CatalogImportExport categoryProcessor does not support escaped delimiter #11801

Merged
merged 1 commit into from
Nov 4, 2017

Conversation

serhii-balko
Copy link
Contributor

@serhii-balko serhii-balko commented Oct 27, 2017

Description

Allow export/import category name with category delimiter character.
After apply this fix, when exporting, the delimiter character in category mane will be quoted.
Example:
"Category / 1" =>"Category\/ 1".
And in import apply conversely process.

Fixed Issues

  1. CatalogImportExport categoryProcessor does not support escaped delimiter #6948: CatalogImportExport categoryProcessor does not support escaped delimiter

Manual testing scenarios

  1. Create Category with name, that contains category delimiter "Category /1 test".
  2. Create any product and asigne this category.
  3. Export this product.
  4. File should be contain category name like "Category\/1 test".
  5. Import this file as "Entity Type"="Products" and "Import Behavior"="Add/Update".
  6. The Category filed in product should remain unchanged.
  7. New category with name "1 test" should not be created.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Nov 1, 2017
@dmanners dmanners added this to the November 2017 milestone Nov 1, 2017
@dmanners dmanners added Release Line: 2.3 2.2.x bug report Component: ImportExport Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 1, 2017
@okorshenko okorshenko merged commit efbf57e into magento:2.3-develop Nov 4, 2017
okorshenko pushed a commit that referenced this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: ImportExport Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants