Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11697 Theme: Added html node to page xml root, cause validation error #11858

Merged
merged 1 commit into from
Nov 4, 2017
Merged

#11697 Theme: Added html node to page xml root, cause validation error #11858

merged 1 commit into from
Nov 4, 2017

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 commented Oct 30, 2017 •
edited
Loading

Description

Theme: Added html node to page xml root, cause validation error
Unify Magento/Framework/View/Layout/etc/layout_merged.xsd and Magento/Framework/View/Layout/etc/page_configuration.xsd declarations.

Fixed Issues (if relevant)

  1. Theme: Added html node to page xml root, cause validation error #11697: Theme: Added html node to page xml root, cause validation error
  2. ...

Manual testing scenarios

As described in #11697

Result after applying this PR:
captura de pantalla 2017-10-30 a las 2 40 00

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@adrian-martinez-interactiv4
Unify Magento/Framework/View/Layout/etc/layout_merged.xsd with Magent…
ec8f96f 
…o/Framework/View/Layout/etc/page_configuration.xsd
@ishakhsuvarov ishakhsuvarov self-assigned this Oct 30, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 30, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit ec8f96f into magento:2.2-develop Nov 4, 2017
okorshenko pushed a commit that referenced this pull request Nov 4, 2017
MAGETWO-82999: #11697 Theme: Added html node to page xml root, cause …
ada5ec9 
…validation error #11858
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 deleted the FR22#THEME-HTML-NODE-PAGE-XML-ROOT branch November 5, 2017 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@adrian-martinez-interactiv4 @magento-team @ishakhsuvarov @okorshenko