Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SalesSequence: Fixed composer installer dependency #1186

Merged
merged 1 commit into from
Apr 16, 2015
Merged

SalesSequence: Fixed composer installer dependency #1186

merged 1 commit into from
Apr 16, 2015

Conversation

therouv
Copy link
Contributor

@therouv therouv commented Apr 13, 2015

Problem:
The dependency in the SalesSequence module for the Magento composer installer is set to "0.74.0-beta4". Unfortunately, this tag does not exist in https://github.com/magento/magento-composer-installer

When trying to install Magento2 via https://github.com/magento/magento2-community-edition this leads to the following error:

  Problem 1
    - Installation request for magento/module-sales-sequence 0.74.0-beta4 -> satisfiable by magento/module-sales-sequence[0.74.0-beta4].
    - magento/module-sales-sequence 0.74.0-beta4 requires magento/magento-composer-installer 0.74.0-beta4 -> no matching package found.

Solution:
Set the dependency to "*" like in every other Magento2 module as well.

@vpelipenko
Copy link
Contributor

CR: passed
Builds: green
Resolution: OK to merge
Internal ticket: MAGETWO-36237

vpelipenko added a commit that referenced this pull request Apr 16, 2015
SalesSequence: Fixed composer installer dependency
@vpelipenko vpelipenko merged commit 3edca36 into magento:develop Apr 16, 2015
magento-team added a commit to abeeskau/magento2-community-edition that referenced this pull request Apr 21, 2015
* Various
    * Added the new methods/fields in the Catalog Product Data Object
    * Improved the Nginx configuration sample file for better web-server responsiveness and security
    * Implemented the new look & feel for Create New Order page
    * Removed the redundant DB constraints for cascade operations related to order management
    * Implemented the mechanism of asynchronous email notifications after creation of Orders, Invoices, Shipments and Credit Memos
    * Moved the join logic on application level in order to make DB separation possible in Reports component
    * Implemented the TTL and event approaches of cache invalidation, introduced the full and the partial Varnish Cache flush
    * Moved all Setup commands to Magento CLI
    * Exposed CMS API as Web API
* Fixed bugs:
    * Unexpected response for API "/V1/customers/password" service
    * Cant include a third-party link to frontend section via layout
    * Specified details for Grouped product are lost after adding to wishlist
    * Impossible to configure products in customer wishlist in Admin Panel
    * Adding the product from wishlist to cart if more than one store view exists
    * Specified product field custom options is not displayed in wishlist in Admin Panel
    * Checkout doesn't work with JS bundling enabled in production mode
    * Issue with price excluding tax when selecting downloadable links
    * Undefined index warning in case the frontend cache information is missing in configuration file
    * "New Order" email is not sent to customer after placing order via API service
    * 503 error when placing order with multiple shipping addresses if mail transport doesn't exist
    * Broken words for fields with long labels all over the Admin Panel
    * Issue with saving 'is_virtual' flag in quote
    * "Void" button available after "Deny Payment" operation
    * Uninstall logic did not clean cache properly
    * Obsolete code tests did not cover Tests folders
    * Random fail of Magento\Log\Test\Unit\Model\VisitorTest
* GitHub issues:
   * [#1149] (magento/magento2#1149) -- Checkout Grand Total amount miscalculation
   * [#1165] (magento/magento2#1165) -- Fix typos
   * [#1182] (magento/magento2#1182) -- Update system.xml for 'fix' sortOrder in adminhtml
   * [#1186] (magento/magento2#1186) -- SalesSequence: Fixed composer installer dependency
magento-team added a commit to abeeskau/magento2-community-edition that referenced this pull request Apr 28, 2015
* Various
    * Added the new methods/fields in the Catalog Product Data Object
    * Improved the Nginx configuration sample file for better web-server responsiveness and security
    * Implemented the new look & feel for Create New Order page
    * Removed the redundant DB constraints for cascade operations related to order management
    * Implemented the mechanism of asynchronous email notifications after creation of Orders, Invoices, Shipments and Credit Memos
    * Moved the join logic on application level in order to make DB separation possible in Reports component
    * Implemented the TTL and event approaches of cache invalidation, introduced the full and the partial Varnish Cache flush
    * Moved all Setup commands to Magento CLI
    * Exposed CMS API as Web API
* Fixed bugs:
    * Unexpected response for API "/V1/customers/password" service
    * Cant include a third-party link to frontend section via layout
    * Specified details for Grouped product are lost after adding to wishlist
    * Impossible to configure products in customer wishlist in Admin Panel
    * Adding the product from wishlist to cart if more than one store view exists
    * Specified product field custom options is not displayed in wishlist in Admin Panel
    * Checkout doesn't work with JS bundling enabled in production mode
    * Issue with price excluding tax when selecting downloadable links
    * Undefined index warning in case the frontend cache information is missing in configuration file
    * "New Order" email is not sent to customer after placing order via API service
    * 503 error when placing order with multiple shipping addresses if mail transport doesn't exist
    * Broken words for fields with long labels all over the Admin Panel
    * Issue with saving 'is_virtual' flag in quote
    * "Void" button available after "Deny Payment" operation
    * Uninstall logic did not clean cache properly
    * Obsolete code tests did not cover Tests folders
    * Random fail of Magento\Log\Test\Unit\Model\VisitorTest
* GitHub issues:
   * [#1149] (magento/magento2#1149) -- Checkout Grand Total amount miscalculation
   * [#1165] (magento/magento2#1165) -- Fix typos
   * [#1182] (magento/magento2#1182) -- Update system.xml for 'fix' sortOrder in adminhtml
   * [#1186] (magento/magento2#1186) -- SalesSequence: Fixed composer installer dependency
magento-team added a commit to abeeskau/magento2-community-edition that referenced this pull request Apr 28, 2015
* Various
    * Added the new methods/fields in the Catalog Product Data Object
    * Improved the Nginx configuration sample file for better web-server responsiveness and security
    * Implemented the new look & feel for Create New Order page
    * Removed the redundant DB constraints for cascade operations related to order management
    * Implemented the mechanism of asynchronous email notifications after creation of Orders, Invoices, Shipments and Credit Memos
    * Moved the join logic on application level in order to make DB separation possible in Reports component
    * Implemented the TTL and event approaches of cache invalidation, introduced the full and the partial Varnish Cache flush
    * Moved all Setup commands to Magento CLI
    * Exposed CMS API as Web API
* Fixed bugs:
    * Unexpected response for API "/V1/customers/password" service
    * Cant include a third-party link to frontend section via layout
    * Specified details for Grouped product are lost after adding to wishlist
    * Impossible to configure products in customer wishlist in Admin Panel
    * Adding the product from wishlist to cart if more than one store view exists
    * Specified product field custom options is not displayed in wishlist in Admin Panel
    * Checkout doesn't work with JS bundling enabled in production mode
    * Issue with price excluding tax when selecting downloadable links
    * Undefined index warning in case the frontend cache information is missing in configuration file
    * "New Order" email is not sent to customer after placing order via API service
    * 503 error when placing order with multiple shipping addresses if mail transport doesn't exist
    * Broken words for fields with long labels all over the Admin Panel
    * Issue with saving 'is_virtual' flag in quote
    * "Void" button available after "Deny Payment" operation
    * Uninstall logic did not clean cache properly
    * Obsolete code tests did not cover Tests folders
    * Random fail of Magento\Log\Test\Unit\Model\VisitorTest
* GitHub issues:
   * [#1149] (magento/magento2#1149) -- Checkout Grand Total amount miscalculation
   * [#1165] (magento/magento2#1165) -- Fix typos
   * [#1182] (magento/magento2#1182) -- Update system.xml for 'fix' sortOrder in adminhtml
   * [#1186] (magento/magento2#1186) -- SalesSequence: Fixed composer installer dependency
magento-team pushed a commit that referenced this pull request Jun 12, 2017
magento-team pushed a commit that referenced this pull request Jan 20, 2018
…lic PR#9647] #1186

 - Merge Pull Request magento-engcom/magento2ce#1186 from p-bystritsky/magento2:ISSUE-12993
 - Merged commits:
   1. 69cad44
   2. dc64138
magento-team pushed a commit that referenced this pull request Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants