Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After logging in customer is now not redirecting to Customer Dashboard by default #11876

Merged
merged 4 commits into from
Nov 11, 2017

Conversation

p-bystritsky
Copy link
Contributor

@p-bystritsky p-bystritsky commented Oct 30, 2017

Description

After logging in customer is now not redirecting to Customer Dashboard by default (based on #10834 (comment)).

Manual testing scenarios

  1. Open Admin -> "Stores" -> "Customers" -> "Customer Configuration" -> "Login Options" -> "Redirect Customer to Account Dashboard after Logging in" and make sure "Use system value" is checked.
  2. On the Storefront create a Customer.
  3. Log out if you are logged in.
  4. Open CMS index page.
  5. Log in with Customer's credentials.
  6. You should be redirected to CMS index page, not to Customer Dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@p-bystritsky
Copy link
Contributor Author

Incorrect implementation and issue is already assigned to another user.

@p-bystritsky p-bystritsky reopened this Oct 31, 2017
@p-bystritsky p-bystritsky changed the title magento/magento2#10834: Signing in after selecting checkout button, will not end up to checkout page After logging in customer is now not redirecting to Customer Dashboard by default Oct 31, 2017
@magento-engcom-team magento-engcom-team added 2.2.x feature request Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko self-assigned this Nov 8, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 8, 2017
@okorshenko okorshenko merged commit c50899e into magento:2.2-develop Nov 11, 2017
okorshenko pushed a commit that referenced this pull request Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants