-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Made method public so a plugin is possible. #11878
[BUGFIX] Made method public so a plugin is possible. #11878
Conversation
Hi @dheesbeen. Change of method from protected to public leads to backward compatibility issue. To solve you problem you can create new class that will contain |
... or just use this new class inside of |
…us-2.2-patch-customer-accountmanagement-is-confirmation-required
b43de35
to
7588df9
Compare
7588df9
to
6227a14
Compare
Hi, @dheesbeen. What is a use case to make plugin on isConfirmationRequired method? What goal you want to achieve? |
It seems pretty clear to me. Logic like
Probably it's possible with existing code by some |
…us-2.2-patch-customer-accountmanagement-is-confirmation-required
…us-2.2-patch-customer-accountmanagement-is-confirmation-required
Customer isConfirmationRequired method exists in two places. In the customer Object and in the accountManagement object
The method in the customer object is public. Which makes it possible to plugin it.
The method in the accountManagement object is protected. Which makes it impossible to plugin it.
This PR only makes the method in isConfirmationRequired in AccountManagement class public.
Fixed Issues (if relevant)