Fix missing discount label in checkout

[allanwebjump]

Description

The discount label was not being shown in the shopping cart totals description

Fixed Issues

1. Discount Rule does not show Default Rule Label #11497: Discount Rule does not show Default Rule Label
2. Cart Price Rule Label is not working #11428: Cart Price Rule Label is not working

Manual testing scenarios

1. Add a discount to quote
2. Go to the shopping cart and now see the discount label in the totals description

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[okorshenko]

Hi @allanwebjump Thank you for your contribution.
We tested 4 use cases for your fix:
Precondition:
Create a product with the price $500. Add product to the cart

✅ Use Case 1

1. Create cart price rule 1 with the following configuration:

• No coupon
• No labels
• Condition: 2 items in the cart
• Action: -50%

2. Add 2 products to the cart

✅ Use Case 2

1. Create cart price rule 2 with the following configuration:

• No coupon
• Label: 3 items - 50%
• Condition: 3 items in the cart
• Action: -50%

2. Add 3 products to the cart
   

✅ Use Case 3

1. Create cart price rule 3 with the following configuration:

• Coupon code: 4products
• No label
• Condition: 4 items in the cart
• Action: -75%

2. Add 4 products to the cart
   

❌ Use Case 4

1. Create cart price rule 4 with the following configuration:

• Coupon code: 5products
• Label: five products - 75%
• Condition: 5 items in the cart
• Action: -75%

2. Add 5 products to the cart
   

❌ The Rule label is rendered twice

Could you please fix the Use case 4 so that we can accept this pull request?
Thank you

[okorshenko]

Hi @allanwebjump
please let me know if you would like to proceed with this PR

[ihor-sviziev]

Actually as a small fix we could just do following change in CSS:

.totals .discount.coupon {
    display: none;
}

[okorshenko]

Hi @allanwebjump
We are closing this PR for now. Please reopen it once ready