Skip to content

[BACKPORT 2.1] [BUGFIX] Add FreeShipping to the Items when SalesRule uses #11919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2017
Merged

[BACKPORT 2.1] [BUGFIX] Add FreeShipping to the Items when SalesRule uses #11919

merged 1 commit into from
Nov 13, 2017

Conversation

lewisvoncken
Copy link
Contributor

…ING_ADDRESS

same as magento-partners/magento2ce#59

Description

When you create a Shopping Cart Price Rule for Free Shipping for shipment with matching items.

Fixed Issues (if relevant)

  1. Free shipping coupon not working with Table Rates shipping - Sorry, no quotes are available for this order. #8172: Free shipping coupon not working with Table Rates shipping - Sorry, no quotes are available for this order.
  2. Cart Price Rules based on Shipping Method can't be applied in basket #8089: Cart Price Rules based on Shipping Method can't be applied in basket
  3. Free shipping not being properly applied in CE 2.1.8 #10507: Free shipping coupon not working with Table Rates shipping - Sorry, no quotes are available for this order.

In issue #8172 there is referenced to the shipping method Table Rates but the issue is for all Offline ShippingMethods

Manual testing scenarios

  1. Create a Shopping Cart Price Rule with the following Options based on issue Free shipping coupon not working with Table Rates shipping - Sorry, no quotes are available for this order. #8172
  • Coupon Code: FREESHIP
  • Enabled from/To: 01/01/2016 - 01/01/2022
  • Apply: Percent of product price discount
  • Discount Amount: 0
  • Discard subsequent rules: YES
  • Apply to Shipping Amount: YES
  • Free Shipping: For Shipment with matching items
  1. Add a product to your shopping cart
  2. Apply the coupon code in your shopping cart
  3. Result is that there is no free shipping calculated

Apply changes and try again and the result will be that there is Free Shipping for the cart.

Before:
image

After:
image

@magento-engcom-team magento-engcom-team added 2.2.x bugfix Component: Checkout Component: Tax Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko self-assigned this Nov 10, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 10, 2017
@okorshenko okorshenko merged commit f310c91 into magento:2.1-develop Nov 13, 2017
okorshenko pushed a commit that referenced this pull request Nov 13, 2017
MAGETWO-83689: [BACKPORT 2.1] [BUGFIX] Add FreeShipping to the Items …
6637cde 
…when SalesRule uses #11919
@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Nov 14, 2017
@apedicdev
Copy link
Contributor

hi, is there an update about this bug? has it been fixed in 2.1 but still reproduced on 2.2 and 2.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
bugfix Component: Checkout Component: Tax Fixed in 2.1.x The issue has been fixed in 2.1 release line Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@lewisvoncken @apedicdev @magento-team @okorshenko @magento-engcom-team