Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use table alias for qty field #1195

Merged
merged 2 commits into from
May 22, 2015
Merged

Use table alias for qty field #1195

merged 2 commits into from
May 22, 2015

Conversation

mikekeilty
Copy link
Contributor

This was an issue with joining tables to the collection used for the lowstock report grid, as the qty field was ambiguous.

This allows Magento to use a table prefix for the qty field, enabling other tables to be joined easily.

@kokoc
Copy link
Member

kokoc commented Apr 17, 2015

@mikekeilty Thank you for the contribution!

✅ CR: passed
✅ Resolution: Ready to merge
✅ Builds: Green
✅ Internal reference: MAGETWO-36413

@mikekeilty
Copy link
Contributor Author

You're welcome!

@vpelipenko vpelipenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 21, 2015
@mikekeilty
Copy link
Contributor Author

I don't know how that merge commit got attached to this pull request, but it was a mistake.

@magento-team magento-team merged commit 08c5817 into magento:develop May 22, 2015
@kokoc
Copy link
Member

kokoc commented May 27, 2015

@mikekeilty your pull request is merged in 0.74.0-beta10. Thank you very much for your contribution and continued support to Magento 2!

magento-team pushed a commit that referenced this pull request Jun 15, 2017
MAGETWO-54066: [GITHUB] Invalid event prefix for catalog inventory #4857
magento-team pushed a commit that referenced this pull request Jan 11, 2018
 - Merge Pull Request magento-engcom/magento2ce#1195 from nmalevanec/magento2:12752
 - Merged commits:
   1. 3967190
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Jun 22, 2018
Introduce InventoryLowQuantityAdminUi module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants