Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11793: Magento2.1.5 admin shipping report shows wrong currency code #11962

Merged
merged 3 commits into from
Nov 9, 2017
Merged

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 2, 2017

Admin reports show only default currency code.

Fixed Issues (if relevant)

  1. Magento2.1.5 admin shipping report shows wrong currency code #11793: Magento2.1.5 admin shipping report shows wrong currency code

Manual testing scenarios

Steps to reproduce:

  1. Create a single website with multi-store views (2 stores).
  2. Go to Stores-Configuration->General->Currency Setup->Currency Options and set it up to show USD currency for the 1 store, and EUR currency (as an example) for the second store.
  3. Create 2 orders for each store (go to Sales->Orders), invoices and shippings for them.
  4. Go to Admin->Reports->Sales->Shipping and set up the filters so you can see shipments for that orders you created earlier.
  5. Currency must change depends on store.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

\Magento\Reports\Block\Adminhtml\Grid\AbstractGrid::class,
['_storeManager' => $this->storeManagerMock]
);

Copy link
Member

@osrecio osrecio Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete blank line before closing brace: Line 44.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osrecio, done.

@ishakhsuvarov ishakhsuvarov self-assigned this Nov 2, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 2, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 2, 2017
@okorshenko okorshenko merged commit 42d9b52 into magento:2.2-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants